-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync with tractus-X #508
Merged
Merged
sync with tractus-X #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) harden test PolicyStoreServiceTest#whenUpdate by asserting that the creation timestamp is not changed and that the validUntil timestamp is changed as expected 2) clean method signature by moving loop from controller to the service method
inlcuding test for helper class
- updatePolicies_shouldAddPolicyToEachBpn - updatePolicies_shouldAddBpnsToEachPolicy
…certian-bpnls # Conflicts: # CHANGELOG.md
…definition-for-certian-bpnls feat(irs-api):[#199] register policy definition for certain bpnls
doc(doc):[#000] add bpn l s and a
…and documentation (the parameter was renamed in https://jira.catena-x.net/browse/TRI-996 from "jobStates" to "states")
chore(collection):[#TRI-996] Correct param "jobStates" in collection …
feat(impl):[XXX] update sb to fix security CVE's
…-for-lookup' into feature/359-registry-update-impl-for-lookup
…for-lookup # Conflicts: # CHANGELOG.md
…mpl-for-lookup feat(impl):[#359] update registry impl for lookup
ds-mwesener
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ds-mwesener
added a commit
that referenced
this pull request
Apr 3, 2024
Merge pull request #508 from catenax-ng/main
ds-jhartmann
pushed a commit
to ds-jhartmann/item-relationship-service
that referenced
this pull request
Jun 13, 2024
…570-adjustments-when-job-running feat(impl):[TRI-1570] update improvment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: