-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): improve documentation of arc42 - cross-cutting #295
Closed
ds-mmaul
wants to merge
7
commits into
eclipse-tractusx:main
from
ds-mmaul:chore(docs)-improve-documentation-2
Closed
chore(docs): improve documentation of arc42 - cross-cutting #295
ds-mmaul
wants to merge
7
commits into
eclipse-tractusx:main
from
ds-mmaul:chore(docs)-improve-documentation-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmf
reviewed
Dec 12, 2023
dsmf
reviewed
Dec 12, 2023
dsmf
reviewed
Dec 12, 2023
dsmf
reviewed
Dec 12, 2023
Besides the minor comments above, this looks good to me |
Co-authored-by: Matthias Fischer <[email protected]>
Co-authored-by: Matthias Fischer <[email protected]>
Co-authored-by: Matthias Fischer <[email protected]>
Co-authored-by: Matthias Fischer <[email protected]>
Resolved conflicts and committed suggestions, PR ready for another review, thanks @dsmf ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
improved documentation in arc42 in the chapter cross-cutting. Went over the chapter and fixed spelling and grammar. In some cases, the choice of words has also been made more precise
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: