Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(irs-api): Removed IRS-Admin role #229

Closed
wants to merge 1 commit into from

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Oct 25, 2023

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@@ -302,7 +302,7 @@ private int getRelationshipsSize(final UUID jobId) {
private static void setSecurityContext() {
JwtAuthenticationToken jwtAuthenticationToken = mock(JwtAuthenticationToken.class);
Jwt token = mock(Jwt.class);
when(jwtAuthenticationToken.getAuthorities()).thenReturn(List.of(new SimpleGrantedAuthority("admin_irs")));
when(jwtAuthenticationToken.getAuthorities()).thenReturn(List.of(new SimpleGrantedAuthority("view_irs")));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use constants

@@ -43,7 +43,7 @@
class SecurityHelperServiceTest {

private final String CLIENT_ID = "sa-cl6-cx-2";
private final String BPN = "BPNL00000003CRHK";
private final String BPN = "BPNL00000001CRHK";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think to not roll that back :-)

ds-jhartmann added a commit that referenced this pull request Feb 22, 2024
Sync main to catena-x-environments
@ds-jhartmann ds-jhartmann deleted the hotfix/remove-admin-role branch May 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants