Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated type-signal in catalog for AAS-Resources #616

Closed
arnoweiss opened this issue May 13, 2024 · 5 comments
Closed

Outdated type-signal in catalog for AAS-Resources #616

arnoweiss opened this issue May 13, 2024 · 5 comments
Assignees
Labels
R24.5 release-hot-fix pbi is relevant for current release and for hotfix path

Comments

@arnoweiss
Copy link

Description

Since R23-12, standard CX-0002 has mandated the use of the property http://purl.org/dc/terms/type to be used as signal the type of a dcat:Dataset in a dcat:Catalog. In an EDC, the corresponding resource must be added during with the POST /v3/assets call, for instance like this [1]. Since its introduction, the property asset:prop:type was due for removal with the next breaking release.

Current behaviour

The IRS relies on the deprecated and (starting R24-05) optional property asset:prop:type [2].

Expected behavior

The IRS (as a Consumer application) should use the Property http://purl.org/dc/terms/type to discover Digital Twin Registries (and Submodels, despite not strictly necessary) in a Provider's catalog. This can be done, for instance, via EDC-Catalog-Filtering, see example [3]. Please note that this property holds an object with an @id property which is why the filter is nested.

If the IRS looks for either or both is an implementation detail. What matters is that Data Providers, adhering only to the current version of the standard are found by the IRS.

[1]
POST /v3/assets

{
  "@context": {
    "edc": "https://w3id.org/edc/v0.0.1/ns/",
    "cx-common": "https://w3id.org/catenax/ontology/common#",
    "dct": "http://purl.org/dc/terms/"
  },
  "@id": "aas-dtr",
  "properties": {
    "dct:type": {"@id": "https://w3id.org/catenax/taxonomy#DigitalTwinRegistry"},
    "cx-common:version": "3.0"
  },
  "privateProperties": {
  },
  "dataAddress": {
    "@type": "DataAddress",
    "type": "HttpData",
    "baseUrl": "https://my-aas.dtr/api/v3.0",
    "oauth2:tokenUrl": "https://my-idp.url/token",
    "oauth2:clientId": "my-cid",
    "oauth2:clientSecretKey":"my-key",
    "proxyMethod": "true",
    "proxyQueryParams": "true",
    "proxyPath": "true"
  }
}

[2]

"Digital Twin Registry Asset", ASSET_CREATION_PROPERTY_TYPE, "data.core.digitalTwinRegistry");

[3]
POST /catalog/request

{
    "@context": {
        "edc": "https://w3id.org/edc/v0.0.1/ns/"
    },
    "@type": "CatalogRequest",
    "counterPartyAddress": "https://counter-party.address/api/v1/dsp",
    "counterPartyId": "BPNL000000FOOBAR",
    "protocol": "dataspace-protocol-http",
    "querySpec": {
        "offset": 0,
        "limit": 200,
        "filterExpression": {
            "operandLeft": "'http://purl.org/dc/terms/type'.'@id'",
            "operator": "=",
            "operandRight": "https://w3id.org/catenax/taxonomy#DigitalTwinRegistry"
        }
    }
}
@github-project-automation github-project-automation bot moved this to inbox in IRS May 13, 2024
@mkanal mkanal moved this from inbox to backlog in IRS May 13, 2024
@mkanal mkanal added R24.5 release-hot-fix pbi is relevant for current release and for hotfix path labels May 13, 2024
@ds-jhartmann
Copy link
Contributor

Hi @arnoweiss
Thank you for raising this issue. I was not aware of this change. We will fix this ASAP.

@ds-jhartmann
Copy link
Contributor

More information about the standard can be found in section 3.1.4 EDC Data Asset Structure of CX-0002

@ds-jhartmann ds-jhartmann moved this from backlog to next in IRS May 13, 2024
@ds-jhartmann ds-jhartmann self-assigned this May 14, 2024
@ds-jhartmann ds-jhartmann moved this from next to wip in IRS May 14, 2024
ds-jhartmann added a commit that referenced this issue May 17, 2024
…ype-signal-in-catalog-for-AAS-Resources

feat(registry):[#616] Add new filter type for digital twin registry c…
@ds-jhartmann ds-jhartmann mentioned this issue May 17, 2024
2 tasks
@ds-jhartmann ds-jhartmann moved this from wip to test in IRS May 17, 2024
@ds-jhartmann
Copy link
Contributor

ds-jhartmann commented May 17, 2024

Fixed in #647

ready for testing @ds-kgassner

@ds-kgassner
Copy link
Contributor

successfully tested - approved from my side.

@ds-jhartmann ds-jhartmann moved this from test to review in IRS May 27, 2024
@mkanal
Copy link
Contributor

mkanal commented Jun 5, 2024

LGFM. PO acceptance in behalf of @jzbmw

@mkanal mkanal closed this as completed Jun 5, 2024
@mkanal mkanal moved this from review to done in IRS Jun 5, 2024
ds-jhartmann pushed a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
…657-change-error-detail

feat(impl):[TRI-1657] adjustments after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R24.5 release-hot-fix pbi is relevant for current release and for hotfix path
Projects
Status: done
Development

No branches or pull requests

4 participants