Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRS Job hung in case BPDM Service is not available and lookupBPNs = true #568

Closed
5 tasks
Tracked by #537
mkanal opened this issue Apr 26, 2024 · 9 comments
Closed
5 tasks
Tracked by #537
Assignees
Labels
bug Something isn't working

Comments

@mkanal
Copy link
Contributor

mkanal commented Apr 26, 2024

Acceptance criteria

  • Set bpdm lookup as deprecated in API
  • Return empty bpns [] over API endpoint
  • Remove code for BPDM lookup
  • Remove documentation
  • Remove bpdm Lookup from INT and e2e tests

Link

Description

Current behaviour

  • job hungs if BPDM service is not available

Expected behavior

  • job response even if bpdm service is not present with correct error message

Steps to reproduce the Bug

  • "lookupBPNs": true
  • BPDM is not available
{
	"aspects": [
		"urn:samm:io.catenax.serial_part:3.0.0#SerialPart",                          
"urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt", 
"urn:samm:io.catenax.just_in_sequence_part:3.0.0#JustInSequencePart", 
"urn:samm:io.catenax.batch:3.0.0#Batch"
	],
	"key": {
		"globalAssetId": urn:uuid:8724338c-5c85-4c34-91eb-e2735d58fb0d
		"bpn": BPNL00000003AVTH
	},
	"collectAspects": true,
	"lookupBPNs" : true,
	"depth" :100,
	"direction" : "downward"
}
@ds-jhartmann
Copy link
Contributor

Planning 2:
might solve the issue with long cucumber integration tests #574

@ds-ext-kmassalski
Copy link
Contributor

PR's:
catenax-ng#905
catenax-ng#907

@dsmf
Copy link
Contributor

dsmf commented May 2, 2024

catenax-ng#907 feat(impl):[#568] insomnia collection update --> approved and merged

@dsmf
Copy link
Contributor

dsmf commented May 2, 2024

catenax-ng#905 feat(impl):[#568] remove bpdm lookup --> approved and merged

@dsmf dsmf mentioned this issue May 2, 2024
2 tasks
@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to test in IRS May 2, 2024
@dsmf
Copy link
Contributor

dsmf commented May 2, 2024

Eclipse TX synch PR:
#583

@dsmf
Copy link
Contributor

dsmf commented May 2, 2024

Hi @ds-ext-kmassalski , it looks like there are some cucumber tests that need to be fixed:
grafik
see this one for example: https://jira.catena-x.net/secure/XrayExecuteTest!default.jspa?testExecIssueKey=TRI-1977&testIssueKey=TRI-1267

ds-jhartmann pushed a commit that referenced this issue May 6, 2024
ds-jhartmann pushed a commit that referenced this issue May 6, 2024
@mkanal
Copy link
Contributor Author

mkanal commented May 8, 2024

@ds-ext-kmassalski

  • And lookupBPNs "false still occurs in Cucumber Tests

  • Was insomnia collection updated?

  • Was bpnLookups removed from JobResponse and documentation as well?

    "bpnLookups": {
    "completed": 0,
    "failed": 0
    }

@ds-ext-kmassalski
Copy link
Contributor

BPN summary removed PR:
#610

ds-jhartmann added a commit that referenced this issue May 13, 2024
@mkanal mkanal moved this from test to review in IRS May 13, 2024
@mkanal mkanal moved this from review to done in IRS May 13, 2024
@mkanal mkanal moved this from done to review in IRS May 13, 2024
@mkanal mkanal moved this from review to done in IRS May 14, 2024
@mkanal
Copy link
Contributor Author

mkanal commented May 14, 2024

PO acceptance in behalf of @jzbmw.
Flag was removed from insomnia / Cucumber tests and jobResponse.

@mkanal mkanal closed this as completed May 14, 2024
ds-jhartmann added a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
…-helm-release-6.7.2

Prepare Helm release for next version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: done
Development

No branches or pull requests

4 participants