Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomprehensible error message of api parameter direction #567

Closed
Tracked by #537
mkanal opened this issue Apr 26, 2024 · 5 comments
Closed
Tracked by #537

Incomprehensible error message of api parameter direction #567

mkanal opened this issue Apr 26, 2024 · 5 comments
Assignees
@ds-ext-kmassalski
Labels
bug Something isn't working R24.5 release-hot-fix pbi is relevant for current release and for hotfix path

Comments

@mkanal
Copy link
Contributor

mkanal commented Apr 26, 2024 •
edited
Loading

Description

Current behaviour

  • Error message in misleading
  • As "upwards" is not correct this fails

Expected behavior

  • Reasonable error message
  • User should now that "upwards" is not a valid paramter this should be "upward"

Steps to reproduce the Bug

`

{
	"key": {
		"globalAssetId": "urn:uuid:c6d2d642-a055-4ddf-87e3-1a3b02c689e3",
		"bpn": "BPNL00000000BJTL"
	},
"direction" :  "upwards",
"lookupBPNs" : true
}

Image
@mkanal mkanal added this to IRS Apr 26, 2024
@github-project-automation github-project-automation bot moved this to inbox in IRS Apr 26, 2024
@mkanal mkanal moved this from inbox to next in IRS Apr 26, 2024
@mkanal mkanal added the bug Something isn't working label Apr 26, 2024
@mkanal mkanal closed this as completed Apr 26, 2024
@mkanal mkanal reopened this Apr 26, 2024
@mkanal mkanal changed the title Incomprehensible error message Incomprehensible error message of api parameter direction Apr 26, 2024
This was referenced Apr 29, 2024
Closed
Closed
@mkanal mkanal moved this from next to backlog in IRS Apr 30, 2024
@mkanal mkanal moved this from backlog to next in IRS Apr 30, 2024
@dsmf dsmf self-assigned this Apr 30, 2024
@ds-ext-kmassalski
Copy link
Contributor

PR:
catenax-ng#906

Changed message to:
image

@ds-ext-kmassalski ds-ext-kmassalski moved this from next to wip in IRS May 1, 2024
@dsmf dsmf mentioned this issue May 2, 2024
Merged
@dsmf
Copy link
Contributor

dsmf commented May 2, 2024 •
edited
Loading

branch: 567-update-message
PR: catenax-ng#906

@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to test in IRS May 2, 2024
@dsmf dsmf mentioned this issue May 2, 2024
Merged
2 tasks
ds-jhartmann pushed a commit that referenced this issue May 2, 2024
@ds-ext-kmassalski
feat(impl):[#567] fix message when wrong direction
ca406f0
ds-jhartmann pushed a commit that referenced this issue May 2, 2024
@dsmf
fix(documentation): [#567] update documentation
6f884c0
ds-jhartmann pushed a commit that referenced this issue May 2, 2024
@dsmf
fix(documentation): [#567] removed invalid user input from message an…
d881bcd 
…d added test
ds-jhartmann pushed a commit that referenced this issue May 2, 2024
@ds-ext-kmassalski
Merge pull request #909 from catenax-ng/feat/567-update-message--review
d5b996e 
fix(documentation): [#567] removed invalid user input from message an…
ds-jhartmann pushed a commit that referenced this issue May 2, 2024
@ds-ext-kmassalski
Merge pull request #906 from catenax-ng/feat/567-update-message
16fa62e 
feat(impl):[#567] fix message when wrong direction
@dsmf
Copy link
Contributor

dsmf commented May 6, 2024

@mkanal , @ds-kgassner -> ready for test

@ds-kgassner
Copy link
Contributor

successfully tested - approved from my side

@dsmf
Copy link
Contributor

dsmf commented May 6, 2024

@jzbmw ready for PO-review

@dsmf dsmf moved this from test to review in IRS May 6, 2024
@jzbmw jzbmw moved this from review to done in IRS May 7, 2024
@jzbmw jzbmw closed this as completed May 7, 2024
@mkanal mkanal unassigned jzbmw and mkanal May 13, 2024
@mkanal mkanal added R24.5 release-hot-fix pbi is relevant for current release and for hotfix path labels May 13, 2024
ds-jhartmann pushed a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
@ds-ext-kmassalski
Merge pull request eclipse-tractusx#567 from catenax-ng/fix/hotfix-3.5.1
c1b2686 
chore(doc): Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ds-ext-kmassalski ds-ext-kmassalski

Labels
bug Something isn't working R24.5 release-hot-fix pbi is relevant for current release and for hotfix path
Projects
IRS
Status: done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dsmf @jzbmw @mkanal @ds-ext-kmassalski @ds-kgassner