Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Configuration of Default Policy HELM configuration #542

Closed
5 tasks done
mkanal opened this issue Apr 16, 2024 · 4 comments
Closed
5 tasks done

Improve Configuration of Default Policy HELM configuration #542

mkanal opened this issue Apr 16, 2024 · 4 comments
Assignees
Labels

Comments

@mkanal
Copy link
Contributor

mkanal commented Apr 16, 2024

As Team
I want a comprehensible standard definition of a policy that is built correctly
so that use a policy that complies with the regulations and is compliant.

Hints / Details

  • ...

Acceptance Criteria

  • Default Policy should be configured in the standard policy ordl schema in the HELM configuration
  • Only one Default Policy could be configured in the yaml HELM configuration
  • Adaption of policy store api according to change
  • Using ORDL Schema of policy in yaml Values.yaml
  • Update arc42 and admin documentation

Out of Scope

  • ...
@mkanal mkanal added this to IRS Apr 16, 2024
@github-project-automation github-project-automation bot moved this to inbox in IRS Apr 16, 2024
@mkanal mkanal added the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Apr 16, 2024
@mkanal mkanal moved this from inbox to backlog in IRS Apr 16, 2024
@mkanal mkanal moved this from backlog to inbox in IRS Apr 16, 2024
@mkanal mkanal moved this from inbox to backlog in IRS Apr 24, 2024
@mkanal mkanal removed the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Apr 24, 2024
@jzbmw jzbmw added the helm label Apr 24, 2024
@mkanal mkanal added the hardening measurements to increase resiliency label Apr 24, 2024
ds-jhartmann pushed a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
…511_create-cucumber-tests

TRI-1511: create cucumber tests for TractionBatteryCode and JustInSequencePart
@mkanal mkanal moved this from backlog to next in IRS Jul 16, 2024
@dsmf dsmf moved this from next to wip in IRS Jul 16, 2024
@mkanal mkanal added the R24.8 label Jul 17, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 17, 2024
…peReference to StringMapper

reason: this allows type-safe mapping to List
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
… old yaml config or from Base64 encoded JSON
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
…JSON, cleanup old code, update documentation and changelog
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 18, 2024
@dsmf
Copy link
Contributor

dsmf commented Jul 18, 2024

PR

#834

Outcome

  • Default policy configuration now uses a JSON array of policies, with each element following the ODRL schema.
  • Initialization from the configured default policy has been adjusted accordingly. It takes the given definition now exactly as it is (e.g. validUntil of the default policy is no longer set programmatically but taken directly from the configuration).
  • The default policies can be entered as multiline text (JSON) in values.yaml file.
  • In the application.yml file Base64 encoding is used because plain JSON caused problems in Spring.
  • The helm template automatically converts the value from values.yaml to Base64.
  • Documentation was updated
  • Tests were adjusted.
  • Tested on DEV

@dsmf dsmf moved this from wip to test in IRS Jul 19, 2024
@dsmf
Copy link
Contributor

dsmf commented Jul 19, 2024

@ds-kgassner, @mkanal ready for test

@ds-kgassner
Copy link
Contributor

  • Tested via Insomnia successfully: Default policy configuration now uses a JSON array of policies, with each element following the ODRL schema.
  • Tested via Insomnia successfully: Initialization from the configured default policy has been adjusted accordingly. It takes the given definition now exactly as it is (e.g. validUntil of the default policy is no longer set programmatically but taken directly from the configuration).
  • Tested successfully: The default policies can be entered as multiline text (JSON) in values.yaml file.
  • Tested via Insomnia successfully and checked files changes: In the application.yml file Base64 encoding is used because plain JSON caused problems in Spring.
  • Tested via Insomnia successfully and checked file changes: The helm template automatically converts the value from values.yaml to Base64.
  • Checked file changes: Tests were adjusted.
  • Administration guide updated

@mkanal mkanal moved this from test to review in IRS Jul 22, 2024
@mkanal mkanal assigned mkanal and unassigned dsmf Jul 22, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jul 22, 2024

IRS will only negotiate contracts for offers with a policy as defined in the Policy Store.
The following configuration value allows the definition of default policies to be used
if no policy has been defined via the Policy Store API.
If the policy check fails, a tombstone will be created and this node will not be processed.
Configure the default policies as JSON array using multiline string here.

LGFM PO acceptance in behalf of @jzbmw

@mkanal mkanal closed this as completed Jul 22, 2024
@mkanal mkanal moved this from review to done in IRS Jul 22, 2024
dsmf added a commit to dsmf/tx-item-relationship-service that referenced this issue Jul 22, 2024
became unused with eclipse-tractusx#542 "Improve Configuration of Default Policy HELM configuration"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: done
Development

No branches or pull requests

4 participants