[Traceability KIT 24.12] Special Characteristics #1064
Conversation
johannsvarela
requested review from
HFocken,
jSchuetz88,
Grand-Thibault and
a team
…racteristics-release-24.12
|
@johannsvarela can you please solve the conflicts? @jSchuetz88 , @eckardg coouls you please check conten wize? Friendly reminder:
|
|
@jSchuetz88 this PR shouldn't be merged until the corresponding aspect model SpecialCharacteristic.Measurement 1.0.0 (#784) is completed and published. Since the aspect model is introduced and described in detail for this KIT, the content of this PR must be adapted after the aspect model was finished. |
|
@johannsvarela same as #1028 (comment) |
|
LGTM |
There was a problem hiding this comment.
Hi @johannsvarela,
looks good. Only two remarks from my side:
- please add a note, that special characteristics are not standardized yet
- please check for the results property (see comment)
There was a problem hiding this comment.
Just a side note, but this changelog will most likely lead to a merge conflict with the changelog from the Block Notification PR.
| } | ||
| ``` | ||
| #### Recommended Pattern (Key Value Pair) | ||
| Due to the amount of different characteristics we opted not to require a specific format for the measurement objects contained in the **"results": [ ]** object list. We rather provide a set of format we recommend to use. These recommendations depend on the most common characteristics and their requirements for the results. |
There was a problem hiding this comment.
In my understanding the result property has been slightly changed with the aspect model (see eclipse-tractusx/sldt-semantic-models#784):
"results": [
{
"identifier": "measurementPoint23",
"description": "This text gives you context to the related measurement to help to put it into the necessary context.",
"unit": "unit:hectopascal",
"value": 12.09,
"measurementTimestamp": "2024-11-22T12:51:38.465+01:00"
}
There was a problem hiding this comment.
@LuisRickert as we prepare the new release for Tractus, please check.
|
Overall PR is release relevant -> model needs to be fixed @LuisRickert, please provide a HOTFIX. |
Description
This PR updates the sections below with new content for special characteristics for the upcoming release 24.12. For detailed information regarding the changes made have a look at the updated changelog file.
Related Issues
Fixes eclipse-tractusx/sig-release#818 / https://github.com/catenax-eV/sig-roadmap/issues/167
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: