chore(kits-structure): rename kits folder name #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanbcbauer
added
the
documentation
|
I am also wondering why we allow blanks in folder names? Shouldn't we define a naming convention for the filenames? Maybe also kebab-case? But this doesn't fit right now to page_adoption-view.md examples within this documentation. |
stephanbcbauer
commented
Oct 19, 2024
| ├── page_adoption-view.md | ||
| ├── page_software-operation-view.md | ||
| └── page_documentation.md | ||
| ``` | ||
|
|
||
| 5. Inside the `NewKIT` folder, add a `SoftwareDevelopmentView` folder that contains a `page_software-development-view.md` file with the content that suits your use case | ||
| 5. Inside the `new-kit` folder, add a `SoftwareDevelopmentView` folder that contains a `page_software-development-view.md` file with the content that suits your use case |
There was a problem hiding this comment.
Why do we describe to add a SoftwareDevelopmentView (shouldn't this also be kebab-case?) but in the example the folder is named Software Development View
arnoweiss
approved these changes
Nov 1, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we already mentioned "Kit folder name should be in kebab-case", this PR also adapts the example folders.
TBH no (only a view) KITs respects this rule :(
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: