-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Explorer Path to the DPP-Verification tutorial for the Tractus-X Community Days #457
Conversation
Please pull the changes from main, I updated our dependency files and workflows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For every image we need to add a .license. In general looks really good, we could merge once it's there. Please make sure that the files do not contain spaces, this can bring problems for different OS.
@matbmoser I have pulled the changes, added to every image in the tutorial an additional license file - as you have mentioned it - and improved the whole process (explorer + builders path) and completed it. so there is no separate aspect-model.md or digital-twin.md, they are now a part of the explorer and builders path, which are at the end linking back to the readme.md file step 3 generating a qr-code. Due to the confussion with the many commits: i swapped test and main branch. |
dpp-tutorial/resources/screenshots/generate_licenses_python_script/generate_licenses.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to pack everything in some commits 88 is much for the fewer changes you made
….md, and DPP links Corrected the DPP v5.0.0 URLs in ReadMe.md update digital-twin-provision.md with collapsible blocks and additional information format improvement for Note and Important sections deleted unnecesary information fixed typo removed class/type from the table + correct order added correct path for guarantee fixed typo and update aspect-model.md with collapsible blocks Corrected the DPP v5.0.0 URLs in ReadMe.md update digital-twin-provision.md with collapsible blocks and additional information format improvement for Note and Important sections deleted unnecesary information
updated ReadMe.md file with explorer and developer path updated ReadMe.md file for more structure deleted typo updated Link to DPP Model updated ReadMe.md builders and explorers path finished explorer path updated visual structure updated structure minor fixes, structure and additional information corrected the steps updated explorer path, updated insomnia http calls link, added additional context information, extended the tabe by the placeholders, given explenation about the EDC Connector, DTR and DS, improved the structure
try: fixing builders and explorer picture minor changes and corrected the builders.png image added href to explorer and builder image
updated example.json payload to the current version added separate dpp json for the explorers as example_explorers.json updated the insomnia request for the explorers added Insomnia tutorial and instructions updated reference link and structure fixed request problem small insomnia explorer path changes changes last HTTPie information to Insomnia updaded insomnia http calls link added insomnia tutorial picture to create a new project, updated the pcf_search_insomnia picture, corrected, updated and improved strcuture of the explorer path
…Id in the car dt template replaced UUID-1 and UUID-2 by digitalTwinId and digitalTwinSubmodelId, added additional data and info saving current progress
chore(license): added licences to the image provided in the tutorial chore: restructured and updated readme builder-path, explorer path and deleted unnecessary files chore: updated the explorer URLs to open in new tabs. chore: deleted unnecessary files chore: updated licenses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to uppercase :)
But wonderful job! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let merge this! Wonderful job @ELebedkin
Why we create this PR?
This PR is necessary to provide the latest version of the showcase demo for the Tractus-X Community Days taking place on December 5th and 6th.
What we want to achieve with this PR?
The goal of this PR is to offer a suitable, non-technical approach that allows business users, experts, and innovation enthusiasts to easily try out the DPP verification process.
What is new?
PR Linked to: