Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ 21° ] Release/v2.1.0/refactor dpp script #207

Merged
merged 8 commits into from
Feb 2, 2024
Merged

[ 21° ] Release/v2.1.0/refactor dpp script #207

merged 8 commits into from
Feb 2, 2024

Conversation

saudkhan116
Copy link
Contributor

Why we create this PR?

This PR contains the following changes:

  • Added pydoc comments to the getPassport.py
  • Added access-token parameter to authorize the APIs without providing username/password and company.
  • Updated logging and readme
  • Updated license header

What we want to achieve with this PR?

To ensure robustness of the dpp script by fixing some issues.

What is new?

Added

  • Added pydoc comments to the getPassport.py
  • Added access-token parameter to authorize the APIs without providing username/password and company

Updated

  • Updated logging and readme
  • Updated license header

@saudkhan116 saudkhan116 requested a review from matbmoser February 2, 2024 18:47
@gitguardian GitGuardian
Copy link

gitguardian bot commented Feb 2, 2024 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@matbmoser matbmoser added this to the v2.1.0 milestone Feb 2, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
.github/workflows/trivy.yml Outdated

- name: Upload Trivy scan results to GitHub Security tab
if: always()
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
.github/workflows/trivy.yml Outdated

- name: Upload Trivy scan results to GitHub Security tab
if: always()
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
.github/workflows/trivy.yml Outdated

- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-frontend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
.github/workflows/publish-dpp-backend-docker-image.yml Dismissed Show dismissed Hide dismissed
Dockerfile Outdated
@@ -62,15 +63,15 @@
HEALTHCHECK NONE

# add permissions for a user
RUN chown -R 10000:3000 /app && chmod -R 775 /app/
RUN chown 10000:3000 /entrypoint.sh && chmod -R 775 /entrypoint.sh
RUN chown -R 1000:3000 /app && chmod -R 775 /app/

Check notice

Code scanning / KICS

Multiple RUN, ADD, COPY, Instructions Listed Note

There are RUN instructions that could be grouped
saudkhan116 pushed a commit that referenced this pull request Feb 2, 2024
@matbmoser
Merge pull request #207 from catenax-ng/feature/cmp-804/create-unit-t…
7cbfb74 
…ests

Feature/cmp 804/create unit tests
@saudkhan116 saudkhan116 added backend Issue or PR connected to the backend application documentation Improvements or additions to documentation labels Feb 2, 2024
@saudkhan116 saudkhan116 merged commit 86dd4aa into eclipse-tractusx:main Feb 2, 2024
6 checks passed
@saudkhan116 saudkhan116 deleted the release/v2.1.0/refactor-dpp-script branch February 2, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbmoser matbmoser matbmoser approved these changes

Assignees
No one assigned
Labels
backend Issue or PR connected to the backend application documentation Improvements or additions to documentation
Projects
Digital Product Pass
Archived in project
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@saudkhan116 @matbmoser