Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ 3° ] - Release/v1.4.0 Bugfix/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id #148

Merged

Conversation

matbmoser
Copy link
Contributor

@matbmoser matbmoser commented Nov 15, 2023

Why we create this PR?

There is a bug related to the search of the digital twin registries, sometimes there is coming no contract id and the backend enters in a loop without retrying the negotiation of contract.

What we want to achieve with this PR?

We want to fix the bug by implementing the necessary changes in the DTR Search Logic

What is new?

Added

  • Fixed the timeout time for each negotiation
  • Added check for empty or null contractIds with retrial
  • Added descriptive logs to search and create methods

Issues Fixed

  • Fixed the long waiting time by implementing timeout when doing the negotiation
  • Fixed the null contract ids creation

@matbmoser matbmoser force-pushed the bugfix/cmp-983/dtr-lookup branch from 109cab1 to b4c4035 Compare November 16, 2023 10:05
@saudkhan116 saudkhan116 changed the title Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id [ 1° ] - Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id Nov 28, 2023
@matbmoser matbmoser requested a review from saudkhan116 December 7, 2023 09:03
@saudkhan116 saudkhan116 changed the title [ 1° ] - Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id [ 3° ] - Release/v1.4.0 Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id Dec 13, 2023
@saudkhan116 saudkhan116 added the bug Something isn't working label Dec 13, 2023
Copy link
Contributor

@saudkhan116 saudkhan116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine, except a small missing/typo

charts/digital-product-pass/values-beta.yaml Outdated Show resolved Hide resolved
charts/digital-product-pass/values-dev.yaml Outdated Show resolved Hide resolved
@matbmoser
Copy link
Contributor Author

Here we need to add the change logs

@saudkhan116 saudkhan116 force-pushed the bugfix/cmp-983/dtr-lookup branch from bc98f8f to 30e97b8 Compare December 13, 2023 16:38
@saudkhan116 saudkhan116 self-requested a review December 13, 2023 16:40
@saudkhan116 saudkhan116 added this to the v1.4.0 milestone Dec 13, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@saudkhan116 saudkhan116 changed the title [ 3° ] - Release/v1.4.0 Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id [ 3° ] - Release/v1.4.0 Bugfix/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id Dec 14, 2023
@saudkhan116
Copy link
Contributor

The ip chceks are executed and nothing was found

@saudkhan116 saudkhan116 merged commit ee78fa5 into eclipse-tractusx:main Dec 14, 2023
5 of 6 checks passed
@saudkhan116 saudkhan116 deleted the bugfix/cmp-983/dtr-lookup branch December 14, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants