-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ 3° ] - Release/v1.4.0 Bugfix/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id #148
Merged
saudkhan116
merged 9 commits into
eclipse-tractusx:main
from
catenax-ng:bugfix/cmp-983/dtr-lookup
Dec 14, 2023
Merged
[ 3° ] - Release/v1.4.0 Bugfix/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id #148
saudkhan116
merged 9 commits into
eclipse-tractusx:main
from
catenax-ng:bugfix/cmp-983/dtr-lookup
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbmoser
force-pushed
the
bugfix/cmp-983/dtr-lookup
branch
from
November 16, 2023 10:05
109cab1
to
b4c4035
Compare
saudkhan116
changed the title
Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id
[ 1° ] - Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id
Nov 28, 2023
saudkhan116
changed the title
[ 1° ] - Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id
[ 3° ] - Release/v1.4.0 Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id
Dec 13, 2023
saudkhan116
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine, except a small missing/typo
Here we need to add the change logs |
saudkhan116
force-pushed
the
bugfix/cmp-983/dtr-lookup
branch
from
December 13, 2023 16:38
bc98f8f
to
30e97b8
Compare
saudkhan116
approved these changes
Dec 13, 2023
matbmoser
commented
Dec 14, 2023
saudkhan116
changed the title
[ 3° ] - Release/v1.4.0 Bugfix/cmp 983/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id
[ 3° ] - Release/v1.4.0 Bugfix/dtr lookup: Fixed bugs related to negotiation timeout and "gost" contract id
Dec 14, 2023
The ip chceks are executed and nothing was found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we create this PR?
There is a bug related to the search of the digital twin registries, sometimes there is coming no contract id and the backend enters in a loop without retrying the negotiation of contract.
What we want to achieve with this PR?
We want to fix the bug by implementing the necessary changes in the DTR Search Logic
What is new?
Added
Issues Fixed