Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5°] - Release/v1.3.0 edc postgres configuration: Resolve EDC postgres database credentials (user and password) #144

Merged
merged 6 commits into from
Nov 3, 2023
Merged

[5°] - Release/v1.3.0 edc postgres configuration: Resolve EDC postgres database credentials (user and password) #144

merged 6 commits into from
Nov 3, 2023

Conversation

saudkhan116
Copy link
Contributor

Why we create this PR?

This PR contains the following changes:

  • There was an issue in the EDC postgres configuration, the database credentials was not configured correctly in helm values
  • There was a condition missing to the code build step in publish dpp backend workflow

What we want to achieve with this PR?

To fix the database configuration and missing confdition in the workflow file.

What is new?

Issues Fixed

  • Fix database credentials in the edc postgres configuration
  • Fix the condition to the publish dpp backend workflow

saudkhan116 and others added 3 commits October 19, 2023 11:59
@saudkhan116
fix: resolve postgres database credentials in edc configuration
256eb4f
@saudkhan116
chore: add condition to the dpp backend workflow
66d4827
@saudkhan116
Merge pull request #187 from catenax-ng/bugfix/cmp-738/edc-postgres-c…
817a825 
…onfiguration

5º - v1.3.0 - Bugfix/cmp 738/edc postgres configuration: Resolve EDC postgres database credentials (user and password)
@saudkhan116 saudkhan116 requested a review from matbmoser November 2, 2023 16:05
@saudkhan116 saudkhan116 added edc-connector Issue or PR related to the EDC Connector helm-charts Issue or PR connected to the helm charts configuration workflows Issue or PR connected to the Github Workflows labels Nov 2, 2023
@saudkhan116 saudkhan116 added this to the v1.3.0 milestone Nov 2, 2023
@matbmoser matbmoser merged commit 150ad03 into eclipse-tractusx:main Nov 3, 2023
4 checks passed
@matbmoser matbmoser deleted the release/v1.3.0-edc-postgres-configuration branch November 3, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbmoser matbmoser Awaiting requested review from matbmoser

Assignees
No one assigned
Labels
edc-connector Issue or PR related to the EDC Connector helm-charts Issue or PR connected to the helm charts configuration workflows Issue or PR connected to the Github Workflows
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@saudkhan116 @matbmoser