Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1º] - Release/v1.2.0 backend refactor: Commented and refactored backend #134

Merged

Conversation

matbmoser
Copy link
Contributor

Why we create this PR?

To add comments and refactor all the code Classes and Methods to become a more reusable code.

What we want to achieve with this PR?

To describe each Classes purposes and the methods with all the parameters and what is done in each method of each class.

What is new?

  • Added comments at every classes explaining their purpose
  • Added comments at every methods explaining what its done, each parameter, what it returns and if it throws exceptions.
  • Added SupressionWarnings("Unused") annotation in every Class and/or method that is unused, to decide if it is to delete or let it be for future use.

@matbmoser matbmoser changed the title Release/v1.2.0 backend refactor: Commented and refactored backend [6º] Release/v1.2.0 backend refactor: Commented and refactored backend Oct 10, 2023
@matbmoser
Copy link
Contributor Author

This PR has many changes because the complete backend was commented and also things were removed in the cleaning from the code.

@matbmoser matbmoser added the backend Issue or PR connected to the backend application label Oct 12, 2023
@matbmoser matbmoser added this to the v1.2.0 milestone Oct 12, 2023
@matbmoser matbmoser changed the title [6º] Release/v1.2.0 backend refactor: Commented and refactored backend [6º] - Release/v1.2.0 backend refactor: Commented and refactored backend Oct 12, 2023
@matbmoser matbmoser changed the title [6º] - Release/v1.2.0 backend refactor: Commented and refactored backend [1º] - Release/v1.2.0 backend refactor: Commented and refactored backend Oct 19, 2023
@matbmoser
Copy link
Contributor Author

I will do an IP check here and we can start to merge

@matbmoser
Copy link
Contributor Author

No dependency is blocking the PR. I checked the changes are valid and made by our team. The amount of changes is understandable since the code needed to be commented.

@matbmoser matbmoser merged commit ca13a9d into eclipse-tractusx:main Oct 30, 2023
4 checks passed
@matbmoser matbmoser deleted the release/v1.2.0-backend-refactor branch October 30, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issue or PR connected to the backend application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants