Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPP] Contract negotiation failing because of CORS and check of "/" at end of provider url in dt #274

Closed
matbmoser opened this issue Apr 15, 2024 · 3 comments · Fixed by #337
Closed

[DPP] Contract negotiation failing because of CORS and check of "/" at end of provider url in dt #274

matbmoser opened this issue Apr 15, 2024 · 3 comments · Fixed by #337
Assignees
@davidzynda
Labels
bug Something isn't working frontend Issue or PR connected to the frontend application PI13
Milestone
v3.1.0

Comments

@matbmoser
Copy link
Contributor

Current Behavior

Usage of CORS is necessary when using two different bsae URLs for backend and frontend.
image-2024-03-14-15-47-15-031
There is a problem with cors with the agree, and negotaition status methods:
Because we send the headers with the forcing of credentials.
This happens when you have the backend and the frontend separated in two instances.

Solution

Remove this property from the frontend
image

Expected Behavior

No CORS errors
@matbmoser matbmoser added the bug Something isn't working label Apr 15, 2024
@matbmoser matbmoser moved this from Planning to Backlog in Digital Product Pass Apr 15, 2024
@matbmoser matbmoser added this to the v3.0.0 (R24.05) milestone Apr 15, 2024
@matbmoser matbmoser added the frontend Issue or PR connected to the frontend application label Apr 15, 2024
@davidzynda davidzynda moved this from Backlog to Review in Digital Product Pass May 2, 2024
@saudkhan116
Copy link
Contributor

The bug is now resolved, but still need to be tested.

@matbmoser matbmoser moved this from Review to Done in Digital Product Pass May 27, 2024
@saudkhan116 saudkhan116 modified the milestones: v3.0.0 (R24.05), v3.1.0 Jun 6, 2024
@matbmoser
Copy link
Contributor Author

This shoudl be solved but where is the change?

https://github.com/eclipse-tractusx/digital-product-pass/blob/8a9745e4483be4c4dfb1bc56009f58f235bc051d/dpp-frontend/src/services/BackendService.js#L289C2-L293C1

Is still in a PR waiting to be merged?

@matbmoser matbmoser mentioned this issue Jun 20, 2024
Merged
saudkhan116 added a commit that referenced this issue Jun 20, 2024
@saudkhan116
fix(frontend): fixed bug #274
1bbd172
@matbmoser
Copy link
Contributor Author

Will be solved in #335

@matbmoser matbmoser mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidzynda davidzynda

Labels
bug Something isn't working frontend Issue or PR connected to the frontend application PI13
Projects
Digital Product Pass
Archived in project
Milestone
v3.1.0
3 participants
@matbmoser @saudkhan116 @davidzynda