Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

chore(helm): remove parent daps key #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(helm): remove parent daps key #42

wants to merge 2 commits into from

Conversation

fty4
Copy link
Member

@fty4 fty4 commented Jun 13, 2023

It is not required to use the daps parent key for the secret elements.
Daps is already know because of the chart name.

If the daps-server is used as dependency then there would be a duplicate daps key:

daps: # dependency chart (alias)
  daps: # this will be removed with this PR
    secret:
      clientId: foo
      clientSecret: bar

Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

fty4 added 2 commits June 13, 2023 11:58
@fty4
chore(helm): remove parent daps key
79fefbf 
It is not required to use the daps parent key for the secret elements. Daps is already know because of the chart name. If the daps-server is used as dependency then there would be a duplicate daps key.
@fty4
chore(helm): remove parent daps key (values-*.yaml)
4938546 
Follow previous change to custom value files
@fty4 fty4 requested a review from adkumar1 June 13, 2023 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adkumar1 adkumar1 Awaiting requested review from adkumar1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fty4