testing: add o.e.tc.datastore.core.tests to testing feature #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTasse
changed the title
PatrickTasse
requested changes
Oct 24, 2024
| @@ -207,4 +207,8 @@ | |||
| id="org.eclipse.tracecompass.slf4j.binding.simple.properties" | |||
| version="0.0.0"/> | |||
|
|
|||
| <plugin | |||
| id="org.eclipse.tracecompass.datastore.core.tests" | |||
There was a problem hiding this comment.
Consider inserting above in alphabetical order
There was a problem hiding this comment.
The Eclipse feature editor added it at the end.
| <plugin | ||
| id="org.eclipse.tracecompass.datastore.core.tests" | ||
| version="0.0.0"/> | ||
|
|
||
| </feature> |
There was a problem hiding this comment.
Other plug-ins that could be considered to be added, here or in another commit if applicable:
o.e.tc.lami.ui.swtbot.tests (fragment)
o.e.tc.analysis.profiling.ui.swtbot.tests
o.e.tc.integration.core.tests
o.e.tc.jsontrace.core.tests
o.e.tc.rcp.ui.tests
There was a problem hiding this comment.
These ones have been missing for a while and have not caused any build issue. It's out of scope of this fix.
I'll fix it. |
Commit e12b98a made o.e.tc.datastore.core.tests a plug-in instead of a fragment. It needs to be part of the testing feature so that downstream test plug-ins can successfully build. Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
fixIncubatorBuild
branch
from
db3065f to
565e41a
Compare
PatrickTasse
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e12b98a made o.e.tc.datastore.core.tests a plug-in instead of a fragment. It needs to be part of the testing feature so that downstream test plug-ins can successfully build.
Signed-off-by: Bernd Hufmann [email protected]