Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timing: set parentId and creation configuration in DataProviderDescriptor for Latency Analysis with conifgurations #171

Merged

Conversation

bhufmann
Copy link
Contributor

@bhufmann bhufmann commented Oct 22, 2024

If a latency analysis was configured using an ITmfConfiguration instance, then set the configuration and parent ID in the Data Provider Descriptors of the corresponding data providers that being spawn by the Latency Analysis (e.g. Latency Statistics, Scatter Chart, Table and Flame Chart). This can be used for to show this information to end users of the trace server front-ends and for grouping of data providers in the front-end implementations.

  • analysis: Set creation configuration to Latency Analysis DataProviderDescriptors
  • timing: Use analysis id as parent ID for latency data providers with configurations.

[Updated] Latency Analysis DataProviderDescriptors with config
[Updated] Latency Analysis DataProviderDescriptors with parentId

Signed-off-by: Bernd Hufmann [email protected]

@bhufmann bhufmann requested a review from PatrickTasse October 23, 2024 12:49
@bhufmann
Copy link
Contributor Author

CI is failing and needs to be fixed

Consider also parent ID and configuration that was missing.

Signed-off-by: Bernd Hufmann <[email protected]>
[Updated] Latency Analysis DataProviderDescriptors with config

Signed-off-by: Bernd Hufmann <[email protected]>
This can be used for grouping on the front-end implementations.

Only apply that for configured latency analysis where ITmfConfiguration
is not null.

[Updated] Latency Analysis DataProviderDescriptors with parentId

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann bhufmann force-pushed the json_parent_config_setting branch from f7fc3b3 to be4ebf4 Compare October 23, 2024 13:16
@bhufmann bhufmann mentioned this pull request Oct 24, 2024
@bhufmann bhufmann merged commit 751b02c into eclipse-tracecompass:master Oct 24, 2024
4 checks passed
@bhufmann bhufmann deleted the json_parent_config_setting branch October 24, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants