tmf: Allow TmfConfiguration to be de-/serialized with GSON #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTasse
requested changes
Oct 21, 2024
| } | ||
| return new TmfConfiguration(this); | ||
| } | ||
| } | ||
| /** | ||
| * Converts a JSON parameters string to {@link ITmfConfiguration} |
There was a problem hiding this comment.
The input is not a string. But I wonder if this method is still needed?
There was a problem hiding this comment.
Yes, it's not needed anymore. I'll remove it.
Also, generate unique UUID as ID from name. [Added] Allow TmfConfiguration to be de-/serialized with GSON [Added] TmfConfiguration.UNKNOWN string if values are not set [Added[ Utility methods to write/read configuration to/from JSON file Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
serializable_configuration
branch
from
c6031c5 to
9a31bf4
Compare
PatrickTasse
approved these changes
Oct 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, generate unique UUID as ID from name.
[Added] Allow TmfConfiguration to be de-/serialized with GSON
[Added] TmfConfiguration.UNKNOWN string if values are not set [Added[ Utility methods to write/read configuration to/from JSON file
Continued from #115
Signed-off-by: Bernd Hufmann [email protected]