tmf: Use ITmfConfiguration configuration create and update methods #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTasse
requested changes
Oct 21, 2024
| } catch (Exception e) { | ||
| throw new TmfConfigurationException("Can't convert input configuration to Map to create configuration", e); //$NON-NLS-1$ | ||
| } | ||
| return create(map); |
There was a problem hiding this comment.
You can just pass configuration.getParameters() directly?
There was a problem hiding this comment.
True. That will make it simpler and not dependency to GSON is added.
| } catch (Exception e) { | ||
| throw new TmfConfigurationException("Can't convert input configuration to Map to update configuration", e); //$NON-NLS-1$ | ||
| } | ||
| return update(id, map); |
There was a problem hiding this comment.
You can just pass configuration.getParameters() directly?
There was a problem hiding this comment.
True. That will make it simpler and not dependency to GSON is added.
bhufmann
force-pushed
the
json_config_in_if
branch
from
8b7844c to
fc2ecef
Compare
PatrickTasse
requested changes
Oct 21, 2024
| * Creates a new configuration instance. | ||
| * <p> | ||
| * The parameters to be provided are described by | ||
| * {@link ITmfConfigurationSourceType#getConfigParamDescriptors()}. |
There was a problem hiding this comment.
by schema or list of ....
| /** | ||
| * Updates a configuration instance. | ||
| * <p> | ||
| * The parameters to be provided are described by |
There was a problem hiding this comment.
by schema or list of ...
- Add new API and default implementation of create and update methods in ITmfConfigurationSource. - Change create method of ITmfDataProviderConfigurator. It has not been released and can be changed. This is as alternative to Map<String, Object>. [Added] ITmfConfiguration configuration create and update methods Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
json_config_in_if
branch
from
fc2ecef to
4b6d1cb
Compare
PatrickTasse
approved these changes
Oct 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as alternative to Map<String, Object>.
[Added] ITmfConfiguration configuration create and update methods
Signed-off-by: Bernd Hufmann [email protected]