tmf: Add support for json-schema file to TmfConfigurationSourceType #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
changed the title
bhufmann
force-pushed
the
json-schema
branch
2 times, most recently
from
6ba8935 to
3015eeb
Compare
bhufmann
force-pushed
the
json-schema
branch
2 times, most recently
from
534d6a2 to
fc21215
Compare
bhufmann
force-pushed
the
json-schema
branch
from
fc21215 to
381d0e4
Compare
PatrickTasse
requested changes
Oct 15, 2024
| @@ -49,4 +52,16 @@ public interface ITmfConfigurationSourceType { | |||
| * @return A list of query parameter descriptors to be passed | |||
| */ | |||
| List<ITmfConfigParamDescriptor> getConfigParamDescriptors(); | |||
| /** | |||
There was a problem hiding this comment.
Missing blank line before
| @@ -49,4 +52,16 @@ public interface ITmfConfigurationSourceType { | |||
| * @return A list of query parameter descriptors to be passed | |||
| */ | |||
| List<ITmfConfigParamDescriptor> getConfigParamDescriptors(); | |||
| /** | |||
| * A string containing a json-schema describing the query parameters | |||
There was a problem hiding this comment.
Gets a file containing...
There was a problem hiding this comment.
done. I added also a link to the schema spec.
| * A string containing a json-schema describing the query parameters | ||
| * to be passed when creating a configuration instance of this type. | ||
| * | ||
| * Note: Use either {@link #getConfigParamDescriptors()} or {@link #getSchemaFile()} |
There was a problem hiding this comment.
For schema specification see https://json-schema.org/ [Added] support for json-schema file to TmfConfigurationSourceType Signed-off-by: Bernd Hufmann <[email protected]>
PatrickTasse
approved these changes
Oct 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For schema specification see https://json-schema.org/
[Added] support for json-schema file to TmfConfigurationSourceType
See eclipse-cdt-cloud/trace-server-protocol#103
Signed-off-by: Bernd Hufmann [email protected]