Counter aspect changes #132
Conversation
Rezix93
force-pushed
the
counterAspectChanges
branch
from
3a14055 to
e444a3c
Compare
...ters.core/src/org/eclipse/tracecompass/analysis/counters/core/aspects/ITmfCounterAspect.java
Show resolved
Hide resolved
| */ | ||
| protected void handleGroupedCounterAspect(ITmfEvent event, ITmfStateSystemBuilder ss, CounterAspect aspect, int rootQuark) { | ||
| protected void handleGroupedCounterAspect(ITmfEvent event, ITmfStateSystemBuilder ss, ITmfCounterAspect aspect, int rootQuark) { |
There was a problem hiding this comment.
This is detected as major API change. I think you have to keep the old signature and deprecated it, and have it call the new signature, casting the aspect to avoid recursion.
With this change, it will only require a minor version bump to 2.3.0, this must be done in the plug-in MANIFEST.MF and will affect all updated @SInCE tags in this commit, to be set to 2.3.
| @@ -81,6 +81,7 @@ public CounterAspect(String fieldName, String label, CounterType type, Class<? e | |||
| * | |||
| * @return the groups | |||
| */ | |||
There was a problem hiding this comment.
Now that it overrides, you can remove the Javadoc here, the one from interface will be used.
| @@ -130,6 +130,7 @@ public boolean equals(@Nullable Object obj) { | |||
| * @return the type of this counter | |||
| * @since 2.1 | |||
| */ | |||
There was a problem hiding this comment.
Now that it overrides, you can remove the Javadoc here, the one from interface will be used.
There was a problem hiding this comment.
It's the Javadoc of getType() that can be removed.
| * @return the groups | ||
| * @since 2.2 | ||
| */ | ||
| default Class<? extends ITmfEventAspect<?>>[] getGroups(){ |
Rezix93
force-pushed
the
counterAspectChanges
branch
2 times, most recently
from
0a8a421 to
7ac254b
Compare
| * @return the groups | ||
| * @since 2.2 | ||
| */ | ||
| default Class<? extends ITmfEventAspect<?>>[] getGroups(){ |
| @@ -81,6 +81,7 @@ public CounterAspect(String fieldName, String label, CounterType type, Class<? e | |||
| * | |||
| * @return the groups | |||
| */ | |||
| @@ -130,6 +130,7 @@ public boolean equals(@Nullable Object obj) { | |||
| * @return the type of this counter | |||
| * @since 2.1 | |||
| */ | |||
| * Key to a relative root of the state system | ||
| * @param aspect | ||
| * Grouped counter aspect | ||
| * @since 2.2 |
There was a problem hiding this comment.
API change requires bump to 2.3.0 in MANIFEST.MF and since tag changed to 2.3 here.
| * Get the groups | ||
| * | ||
| * @return the groups | ||
| * @since 2.2 |
There was a problem hiding this comment.
API change requires bump to 2.3.0 in MANIFEST.MF and since tag changed to 2.3 here.
| * Gets the type of this counter | ||
| * | ||
| * @return the type of this counter | ||
| * @since 2.2 |
There was a problem hiding this comment.
API change requires bump to 2.3.0 in MANIFEST.MF and since tag changed to 2.3 here.
There was a problem hiding this comment.
also missing a @return tag
Rezix93
force-pushed
the
counterAspectChanges
branch
2 times, most recently
from
87a6529 to
1482a21
Compare
| * {@inheritDoc} | ||
| * | ||
| * This is a conservative equals. It only works on very identical aspects. | ||
| */ |
There was a problem hiding this comment.
I think this one should stay, it extends the inherited Javadoc.
| @@ -130,6 +130,7 @@ public boolean equals(@Nullable Object obj) { | |||
| * @return the type of this counter | |||
| * @since 2.1 | |||
| */ | |||
There was a problem hiding this comment.
It's the Javadoc of getType() that can be removed.
| * Get the groups | ||
| * | ||
| * @return the groups | ||
| * @since 2.2 |
| * Gets the type of this counter | ||
| * | ||
| * @return the type of this counter | ||
| * @since 2.2 |
| * Gets the type of this counter | ||
| * | ||
| * @return the type of this counter | ||
| * @since 2.2 |
There was a problem hiding this comment.
also missing a @return tag
Rezix93
force-pushed
the
counterAspectChanges
branch
from
1482a21 to
7a2e4f0
Compare
[Changed] Allowed ITmfCounterAspect populate counterAnalysis Signed-off-by: Reza Rouhghalandari <[email protected]>
No description provided.