Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadedHistoryTreeBackend missing intervals in query2D #158

Closed
PatrickTasse opened this issue Sep 23, 2024 · 0 comments · Fixed by #159
Closed

ThreadedHistoryTreeBackend missing intervals in query2D #158

PatrickTasse opened this issue Sep 23, 2024 · 0 comments · Fixed by #159
Milestone
10.2.0

Comments

@PatrickTasse
Copy link
Contributor

In https://git.eclipse.org/r/134665 a 'reverse' parameter was added to the signature of the IStateHistoryBackend.query2D() interface.

The state system was changed to call this new method. But ThreadedHistoryTreeBackend was not updated to implement this method, and therefore the implementation in base class HistoryTreeBackend is used. The base class is not aware of and misses intervals that are currently held in the interval queue (BufferedBlockingQueue) waiting to be written to file.
PatrickTasse added a commit to PatrickTasse/org.eclipse.tracecompass that referenced this issue Sep 23, 2024
@PatrickTasse
statesystem: Implement new query2D API in ThreadedHistoryTreeBackend
578f3ec 
The new API for query2D with reverse parameter is implemented in
ThreadedHistoryTreeBackend. This avoids the base class implementation
from being used, which is missing queued intervals.

Fixes eclipse-tracecompass#158

[Fixed] Implement new query2D API in ThreadedHistoryTreeBackend\

Signed-off-by: Patrick Tasse <[email protected]>
@PatrickTasse PatrickTasse mentioned this issue Sep 23, 2024
Merged
@PatrickTasse PatrickTasse added this to the 10.2.0 milestone Sep 23, 2024
PatrickTasse added a commit that referenced this issue Sep 30, 2024
@PatrickTasse
statesystem: Implement new query2D API in ThreadedHistoryTreeBackend
e132a19 
The new API for query2D with reverse parameter is implemented in
ThreadedHistoryTreeBackend. This avoids the base class implementation
from being used, which is missing queued intervals.

Fixes #158

[Fixed] Implement new query2D API in ThreadedHistoryTreeBackend\

Signed-off-by: Patrick Tasse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.2.0
1 participant
@PatrickTasse