Added current target version

[JonasHelming]

Add a new column to the compatibility report for a fixed VS Code version. This version is the current target reference version for compatibility, i.e. we aim to complete all missing API of this version.

fixed #17

Signed-off-by: Jonas Helming [email protected]

[jfaltermeier]

Thanks, lgtm!

[vince-fugnitto]

I'm fine with the changes if we believe it has value, but I do have two suggestions:

1. We should display our current coverage for the version we officially support (v1.53.2). I believe it is more meaningful then an arbitrary version we aim to target. We can have both, but 1.53.2 is likely more important.
2. If we aim to support 1.55.2 (given you mentioned it is reasonably close to completion), then we can update our default API to this version, and rather than hardcode the value in this repo we simply read it from the main repo (means we won't need to update this repo).

[JonasHelming]

I'm fine with the changes if we believe it has value, but I do have two suggestions:

1. We should display our current coverage for the version we officially support (v1.53.2). I believe it is more meaningful then an arbitrary version we aim to target. We can have both, but 1.53.2 is likely more important.

makes perfect sense, I added it

2. If we aim to support 1.55.2 (given you mentioned it is reasonably close to completion), then we can update our default API to this version, and rather than hardcode the value in this repo we simply read it from the main repo (means we won't need to update this repo).

I am not sure I understand this. If we raise the default API in the main repo, wouldn't we claim we support a version before we actually do?

[vince-fugnitto]

I am not sure I understand this. If we raise the default API in the main repo, wouldn't we claim we support a version before we actually do?

We bump the API when we have a general idea that most things are supported. Given that we will soon have the new monaco, and you mentioned things are for the majority already supported we should already be thinking of bumping the API again. (There is no guarantee that everything in 1.53.2 is actually supported today either).

[JonasHelming]

OK, but still I would claim that "target reference version" and "current reference version" are two different things. We could actually get the "currently reference version" from the main repo, not the target

[vince-fugnitto]

OK, but still I would claim that "target reference version" and "current reference version" are two different things. We could actually get the "currently reference version" from the main repo, not the target

Correct, the current version should be pulled from the repo, the target should be something we decide as a community makes sense to aim for.

[JonasHelming]

Do you have the location at hand where the version is define in the main repo? Otherwise I will look for it myself

[vince-fugnitto]

Do you have the location at hand where the version is define in the main repo? Otherwise I will look for it myself

I linked it in #18 (comment):

• https://github.com/eclipse-theia/theia/blob/432602946323bc1500c585de4432021b6d6a4a0a/dev-packages/application-package/src/api.ts#L21