Implement CustomExecution extension API #9189

shyshywhy · 2021-03-12T06:58:31Z

Fixes: #7185
Fixes: #8767

What it does

Implement CustomExecution extension API, and fixed issue: #7185, #8767

How to test

Use Gradle Tasks extension to test.

Review checklist

as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

shyshywhy · 2021-03-12T07:09:08Z

azatsarynnyy · 2021-03-12T10:14:38Z

Hello @shyshywhy,
thank you for your contribution to Theia project!

eclipsefdn/eca status check isn't passed which means you have to sign an Eclipse Contributor Agreement before contributing the code.
By the following link https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Eclipse_Contributor_Agreement
you can find all the required information on how to sign an ECA.

shyshywhy · 2021-03-14T03:53:02Z

@azatsarynnyy Ok, I fixed it.

packages/task/src/node/custom/custom-task-runner-backend-module.ts

packages/task/src/node/custom/custom-task-runner.ts

packages/terminal/src/browser/terminal-widget-impl.ts

kittaakos · 2021-03-15T14:35:46Z

I will have time for a full-blown review and verification tomorrow. Please bear with me. Thanks!

kittaakos · 2021-03-16T10:21:21Z

I am verifying the PR with the task-provider-sample from here.

Steps:

Run Task...
custombuildscript: 32.
Continue without scanning the task output.
Task terminates, see the Terminal will be reused by task, press Enter.

logger-protocol.ts:112 root ERROR The ws channel does not exist 23
log @ logger-protocol.ts:111
(anonymous) @ logger-frontend-module.ts:40
(anonymous) @ logger.ts:311
(anonymous) @ logger.ts:303
Promise.then (async)
../../packages/core/lib/common/logger.js.Logger.log @ logger.ts:298
log @ logger.ts:44
../../packages/core/lib/common/messaging/abstract-connection-provider.js.AbstractConnectionProvider.handleIncomingRawMessage @ abstract-connection-provider.ts:112
WebSocketConnectionProvider.socket.onmessage @ ws-connection-provider.ts:63
ReconnectingWebSocket._handleMessage @ reconnecting-websocket-mjs.js:172
main.js:904 Uncaught (in promise) Error: Connection got disposed.
    at Object.dispose (main.js:904)
    at Object.disposable.dispose (disposable.ts:96)
    at DisposableCollection.../../packages/core/lib/common/disposable.js.DisposableCollection.dispose (disposable.ts:74)
    at DisposableCollection.disposable.dispose (disposable.ts:96)
    at DisposableCollection.disposable.dispose (disposable.ts:96)
    at DisposableCollection.../../packages/core/lib/common/disposable.js.DisposableCollection.dispose (disposable.ts:74)
    at TerminalWidgetImpl.../../packages/core/lib/browser/widgets/widget.js.BaseWidget.dispose (widget.ts:68)
    at TerminalWidgetImpl.push.../../packages/terminal/lib/browser/terminal-widget-impl.js.TerminalWidgetImpl.dispose (terminal-widget-impl.ts:603)
    at terminal-widget-impl.ts:695
    at HTMLTextAreaElement.<anonymous> (widget.ts:226)

shyshywhy · 2021-03-16T13:23:22Z

I am verifying the PR with the task-provider-sample from here.

Steps:

Run Task...
custombuildscript: 32.
Continue without scanning the task output.
Task terminates, see the Terminal will be reused by task, press Enter.

logger-protocol.ts:112 root ERROR The ws channel does not exist 23
log @ logger-protocol.ts:111
(anonymous) @ logger-frontend-module.ts:40
(anonymous) @ logger.ts:311
(anonymous) @ logger.ts:303
Promise.then (async)
../../packages/core/lib/common/logger.js.Logger.log @ logger.ts:298
log @ logger.ts:44
../../packages/core/lib/common/messaging/abstract-connection-provider.js.AbstractConnectionProvider.handleIncomingRawMessage @ abstract-connection-provider.ts:112
WebSocketConnectionProvider.socket.onmessage @ ws-connection-provider.ts:63
ReconnectingWebSocket._handleMessage @ reconnecting-websocket-mjs.js:172
main.js:904 Uncaught (in promise) Error: Connection got disposed.
    at Object.dispose (main.js:904)
    at Object.disposable.dispose (disposable.ts:96)
    at DisposableCollection.../../packages/core/lib/common/disposable.js.DisposableCollection.dispose (disposable.ts:74)
    at DisposableCollection.disposable.dispose (disposable.ts:96)
    at DisposableCollection.disposable.dispose (disposable.ts:96)
    at DisposableCollection.../../packages/core/lib/common/disposable.js.DisposableCollection.dispose (disposable.ts:74)
    at TerminalWidgetImpl.../../packages/core/lib/browser/widgets/widget.js.BaseWidget.dispose (widget.ts:68)
    at TerminalWidgetImpl.push.../../packages/terminal/lib/browser/terminal-widget-impl.js.TerminalWidgetImpl.dispose (terminal-widget-impl.ts:603)
    at terminal-widget-impl.ts:695
    at HTMLTextAreaElement.<anonymous> (widget.ts:226)

I fixed it, and fixed some problems found by my own test.

kittaakos · 2021-03-16T13:40:11Z

I fixed it, and fixed some problems found by my own test.

Thank you so much, you work blazing fast. I cannot catch up with your pace... I added a few comments here and there, none of them are crucial. Can you please look into them?

I am going to fetch your changes and keep on with the verification. I noticed an issue with the missing exitCode and signal. Maybe you have already fixed them.

packages/plugin-ext/src/plugin/types-impl.ts

packages/task/src/node/custom/custom-task.ts

packages/task/src/node/task-server.ts

packages/terminal/src/browser/terminal-widget-impl.ts

packages/task/src/node/custom/custom-task-runner.ts

packages/plugin-ext/src/plugin/tasks/tasks.ts

packages/plugin-ext/src/main/browser/tasks-main.ts

packages/plugin-ext/src/plugin/tasks/tasks.ts

packages/plugin-ext/src/plugin/terminal-ext.ts

packages/task/src/node/custom/custom-task-runner.ts

packages/task/src/node/custom/custom-task.ts

shyshywhy · 2021-03-17T09:45:34Z

@kittaakos I fixed the above problem and merged it into the previous commit

kittaakos · 2021-03-23T10:40:59Z

Fixes: #8767

It does not really fix this issue. Although vscode.CustomExecution works, the Gradle task view is not populated in Theia. It works in VS Code. I found these errors when testing the vscode.CustomExecution with the Gradle Tasks extension:

plugin-contribution-handler.ts:382 Uncaught (in promise) Error: command 'gradle.refresh' not found
    at PluginContributionHandler.<anonymous> (plugin-contribution-handler.ts:382)
    at step (plugin-contribution-handler.ts:15)
    at Object.next (plugin-contribution-handler.ts:15)
    at plugin-contribution-handler.ts:15
    at new Promise (<anonymous>)
    at push.../../packages/plugin-ext/lib/main/browser/plugin-contribution-handler.js.__awaiter (plugin-contribution-handler.ts:15)
    at Object.execute (plugin-contribution-handler.ts:379)
    at CommandRegistry.<anonymous> (command.ts:294)
    at step (command.ts:15)
    at Object.next (command.ts:15)
plugin-contribution-handler.ts:382 Uncaught (in promise) Error: command 'gradle.runBuild' not found
    at PluginContributionHandler.<anonymous> (plugin-contribution-handler.ts:382)
    at step (plugin-contribution-handler.ts:15)
    at Object.next (plugin-contribution-handler.ts:15)
    at plugin-contribution-handler.ts:15
    at new Promise (<anonymous>)
    at push.../../packages/plugin-ext/lib/main/browser/plugin-contribution-handler.js.__awaiter (plugin-contribution-handler.ts:15)
    at Object.execute (plugin-contribution-handler.ts:379)
    at CommandRegistry.<anonymous> (command.ts:294)
    at step (command.ts:15)
    at Object.next (command.ts:15)
plugin-contribution-handler.ts:382 Uncaught (in promise) Error: command 'gradle.explorerFlat' not found
    at PluginContributionHandler.<anonymous> (plugin-contribution-handler.ts:382)
    at step (plugin-contribution-handler.ts:15)
    at Object.next (plugin-contribution-handler.ts:15)
    at plugin-contribution-handler.ts:15
    at new Promise (<anonymous>)
    at push.../../packages/plugin-ext/lib/main/browser/plugin-contribution-handler.js.__awaiter (plugin-contribution-handler.ts:15)
    at Object.execute (plugin-contribution-handler.ts:379)
    at CommandRegistry.<anonymous> (command.ts:294)
    at step (command.ts:15)
    at Object.next (command.ts:15)

root ERROR [hosted-plugin: 20438] Promise rejection not handled in one second: Error: argument does not match one of these constraints: arg instanceof constraint, arg.constructor === constraint, nor constraint(arg) === true , reason: Error: argument does not match one of these constraints: arg instanceof constraint, arg.constructor === constraint, nor constraint(arg) === true
root ERROR [hosted-plugin: 20438] With stack trace: Error: argument does not match one of these constraints: arg instanceof constraint, arg.constructor === constraint, nor constraint(arg) === true
    at validateConstraint (file:///Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:16287:19)
    at Object.validateConstraints (file:///Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:16262:13)
    at idOrCommand.handler (file:///Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:82213:29)
    at InstantiationService.invokeFunction (file:///Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:84046:27)
    at Object.execute (file:///Users/akos.kitta/git/theia/examples/electron/lib/68.bundle.js:601:64)
    at CommandRegistry.<anonymous> (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:133591:62)
    at step (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:133368:23)
    at Object.next (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:133349:53)
    at fulfilled (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:133340:58)

Uncaught Error: Language client is not ready yet

Error: Language client is not ready yet
    at T.sendRequest (/Users/akos.kitta/.theia/extensions/redhat.java-0.76.0/extension/dist/extension.js:1)
    at o (/Users/akos.kitta/.theia/extensions/redhat.java-0.76.0/extension/dist/extension.js:9)
    at Object.provideFoldingRanges (/Users/akos.kitta/.theia/extensions/redhat.java-0.76.0/extension/dist/extension.js:9)
    at FoldingProviderAdapter.provideFoldingRanges (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages/folding.js:31)
    at /Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:427
    at LanguagesExtImpl.<anonymous> (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:156)
    at step (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:48)
    at Object.next (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:29)
    at /Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:23
    at new Promise (<anonymous>)
    at /Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:1607
bundle.js:133596 Uncaught (in promise) Error: The command '__plugin.view.title.action.gradle.explorerFlat' cannot be executed. There are no active handlers available for the command.
    at CommandRegistry.<anonymous> (bundle.js:133596)
    at step (bundle.js:133368)
    at Object.next (bundle.js:133349)
    at bundle.js:133343
    at new Promise (<anonymous>)
    at ../../packages/core/lib/common/command.js.__awaiter (bundle.js:133339)
    at CommandRegistry.../../packages/core/lib/common/command.js.CommandRegistry.executeCommand (bundle.js:133581)
    at TabBarToolbar._this.executeCommand (bundle.js:121921)
    at HTMLUnknownElement.callCallback (bundle.js:51456)
    at Object.invokeGuardedCallbackDev (bundle.js:51505)

kittaakos · 2021-03-23T10:54:17Z

I found an error when playing with the Gradle Tasks extension:

Clone https://github.com/jitpack/gradle-simple,
Open in a Theia workspace,
Build starts, Gradle config starts 👍,
See the thumbs-up in the status bar, click on it,
Nothing happens, see the error in the log.

Uncaught (in promise) Error: Run task config does not return after being started
    at TasksExtImpl.<anonymous> (/Users/akos.kitta/gi…/tasks/tasks.js:254)
    at step (/Users/akos.kitta/gi…n/tasks/tasks.js:48)
    at Object.next (/Users/akos.kitta/gi…n/tasks/tasks.js:29)
    at fulfilled (/Users/akos.kitta/gi…n/tasks/tasks.js:20)
    at processTicksAndRejections (/Users/akos.kitta/gi…s/task_queues.js:94)

kittaakos · 2021-03-23T12:25:26Z

Unfortunately, there is another issue. When I install the Language Support for Java(TM) by Red Hat VSX, I can check the build status task with the following command:

In VS Code, it shows the terminal that runs the task:

In Theia, I always see this:

But the task is not active anymore.

kittaakos · 2021-03-23T12:26:35Z

The PR looks very promising, @shyshywhy. If you need assistance with the bug-fixes, let me know, and I try to chime in into the development. Thank you so much for your help so far 🙏

shyshywhy · 2021-03-26T03:41:54Z

Fixes: #8767

It does not really fix this issue. Although vscode.CustomExecution works, the Gradle task view is not populated in Theia. It works in VS Code. I found these errors when testing the vscode.CustomExecution with the Gradle Tasks extension:

plugin-contribution-handler.ts:382 Uncaught (in promise) Error: command 'gradle.refresh' not found
    at PluginContributionHandler.<anonymous> (plugin-contribution-handler.ts:382)
    at step (plugin-contribution-handler.ts:15)
    at Object.next (plugin-contribution-handler.ts:15)
    at plugin-contribution-handler.ts:15
    at new Promise (<anonymous>)
    at push.../../packages/plugin-ext/lib/main/browser/plugin-contribution-handler.js.__awaiter (plugin-contribution-handler.ts:15)
    at Object.execute (plugin-contribution-handler.ts:379)
    at CommandRegistry.<anonymous> (command.ts:294)
    at step (command.ts:15)
    at Object.next (command.ts:15)
plugin-contribution-handler.ts:382 Uncaught (in promise) Error: command 'gradle.runBuild' not found
    at PluginContributionHandler.<anonymous> (plugin-contribution-handler.ts:382)
    at step (plugin-contribution-handler.ts:15)
    at Object.next (plugin-contribution-handler.ts:15)
    at plugin-contribution-handler.ts:15
    at new Promise (<anonymous>)
    at push.../../packages/plugin-ext/lib/main/browser/plugin-contribution-handler.js.__awaiter (plugin-contribution-handler.ts:15)
    at Object.execute (plugin-contribution-handler.ts:379)
    at CommandRegistry.<anonymous> (command.ts:294)
    at step (command.ts:15)
    at Object.next (command.ts:15)
plugin-contribution-handler.ts:382 Uncaught (in promise) Error: command 'gradle.explorerFlat' not found
    at PluginContributionHandler.<anonymous> (plugin-contribution-handler.ts:382)
    at step (plugin-contribution-handler.ts:15)
    at Object.next (plugin-contribution-handler.ts:15)
    at plugin-contribution-handler.ts:15
    at new Promise (<anonymous>)
    at push.../../packages/plugin-ext/lib/main/browser/plugin-contribution-handler.js.__awaiter (plugin-contribution-handler.ts:15)
    at Object.execute (plugin-contribution-handler.ts:379)
    at CommandRegistry.<anonymous> (command.ts:294)
    at step (command.ts:15)
    at Object.next (command.ts:15)

root ERROR [hosted-plugin: 20438] Promise rejection not handled in one second: Error: argument does not match one of these constraints: arg instanceof constraint, arg.constructor === constraint, nor constraint(arg) === true , reason: Error: argument does not match one of these constraints: arg instanceof constraint, arg.constructor === constraint, nor constraint(arg) === true
root ERROR [hosted-plugin: 20438] With stack trace: Error: argument does not match one of these constraints: arg instanceof constraint, arg.constructor === constraint, nor constraint(arg) === true
    at validateConstraint (file:///Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:16287:19)
    at Object.validateConstraints (file:///Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:16262:13)
    at idOrCommand.handler (file:///Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:82213:29)
    at InstantiationService.invokeFunction (file:///Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:84046:27)
    at Object.execute (file:///Users/akos.kitta/git/theia/examples/electron/lib/68.bundle.js:601:64)
    at CommandRegistry.<anonymous> (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:133591:62)
    at step (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:133368:23)
    at Object.next (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:133349:53)
    at fulfilled (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:133340:58)

Uncaught Error: Language client is not ready yet

Error: Language client is not ready yet
    at T.sendRequest (/Users/akos.kitta/.theia/extensions/redhat.java-0.76.0/extension/dist/extension.js:1)
    at o (/Users/akos.kitta/.theia/extensions/redhat.java-0.76.0/extension/dist/extension.js:9)
    at Object.provideFoldingRanges (/Users/akos.kitta/.theia/extensions/redhat.java-0.76.0/extension/dist/extension.js:9)
    at FoldingProviderAdapter.provideFoldingRanges (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages/folding.js:31)
    at /Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:427
    at LanguagesExtImpl.<anonymous> (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:156)
    at step (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:48)
    at Object.next (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:29)
    at /Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/languages.js:23
    at new Promise (<anonymous>)
    at /Users/akos.kitta/git/theia/examples/electron/lib/vs/editor/editor.main.js:1607
bundle.js:133596 Uncaught (in promise) Error: The command '__plugin.view.title.action.gradle.explorerFlat' cannot be executed. There are no active handlers available for the command.
    at CommandRegistry.<anonymous> (bundle.js:133596)
    at step (bundle.js:133368)
    at Object.next (bundle.js:133349)
    at bundle.js:133343
    at new Promise (<anonymous>)
    at ../../packages/core/lib/common/command.js.__awaiter (bundle.js:133339)
    at CommandRegistry.../../packages/core/lib/common/command.js.CommandRegistry.executeCommand (bundle.js:133581)
    at TabBarToolbar._this.executeCommand (bundle.js:121921)
    at HTMLUnknownElement.callCallback (bundle.js:51456)
    at Object.invokeGuardedCallbackDev (bundle.js:51505)

For this issue, i have fixed, but not sure if the repair is appropriate.

In the Task, updateDefinitionBasedOnExecution will modify the type of TaskDefinition, resulting in plugin judgment errors.

private updateDefinitionBasedOnExecution(): void {
        if (this.taskExecution instanceof ProcessExecution) {
            Object.assign(this.taskDefinition, {
                type: 'process',
                id: this.taskExecution.computeId(),
                taskType: this.taskDefinition!.type
            });
        } else if (this.taskExecution instanceof ShellExecution) {
            Object.assign(this.taskDefinition, {
                type: 'shell',
                id: this.taskExecution.computeId(),
                taskType: this.taskDefinition!.type
            });
        } else if (this.taskExecution instanceof CustomExecution) {
            Object.assign(this.taskDefinition, {
                type: 'customExecution',
                id: this.taskExecution.computeId(),
                taskType: this.taskDefinition!.type
            });
        } else {
            Object.assign(this.taskDefinition, {
                type: '$empty',
                id: UUID.uuid4(),
                taskType: this.taskDefinition!.type
            });
        }
    }

so, i change it, but it’s not clear if it conflicts with theia design

shyshywhy · 2021-03-26T03:44:56Z

Unfortunately, there is another issue. When I install the Language Support for Java(TM) by Red Hat VSX, I can check the build status task with the following command:

In VS Code, it shows the terminal that runs the task:

In Theia, I always see this:

But the task is not active anymore.

I think can open another issue to track this issue.

The reason for this problem is that the repeated judgment of the task does not distinguish the client, and there is no recovery mechanism after the terminal is closed.

kittaakos · 2021-03-30T08:07:02Z

Although vscode.CustomExecution works, the Gradle task view is not populated in Theia.

👍 This works now:

kittaakos · 2021-03-30T13:02:11Z

Thank you for the update, @shyshywhy. I will approve your changes and leave the PR open for a few more days if someone else wants to chime in and try it in action. I have not used the vscode.CustomExecution before, but I have tried the followings with your changeset:

Overall, it's a great improvement. Thank you so much for your help 👍

There are a few issues I have noticed. We can fix them later:

Somehow, I managed to get an error when opening the terminal for a task. I am not sure how to reproduce it:

command.ts:15 Uncaught (in promise) Error: Run task config does not return after being started
    at TasksExtImpl.<anonymous> (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/tasks/tasks.js:254)
    at step (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/tasks/tasks.js:48)
    at Object.next (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/tasks/tasks.js:29)
    at fulfilled (/Users/akos.kitta/git/theia/packages/plugin-ext/lib/plugin/tasks/tasks.js:20)
    at processTicksAndRejections (internal/process/task_queues.js:94)

When a task is finished, I can see the 👍 (thumbs-up icon) in the status bar, when I click on it, I see the notification with the action, but I cannot reopen the terminal for the task. (See here.)
If I am not mistaken, Theia does create an identifier for a task. VS Code has a KeyedTaskIdentifier that can be used if two tasks are the "same". VS Code can report that a "same" task is already running, or here is the result of that task.
When trying the Gradle Tasks VS Code extension, I got this: (unrelated to this PR)

Error: Language client is not ready yet
    at T.sendRequest (/Users/akos.kitta/.t…dist/extension.js:1)
    at o (/Users/akos.kitta/.t…dist/extension.js:9)
    at Object.provideFoldingRanges (/Users/akos.kitta/.t…dist/extension.js:9)
    at FoldingProviderAdapter.provideFoldingRanges (/Users/akos.kitta/gi…uages/folding.js:31)
    at /Users/akos.kitta/gi…in/languages.js:427
    at LanguagesExtImpl.<anonymous> (/Users/akos.kitta/gi…in/languages.js:156)
    at step (/Users/akos.kitta/gi…gin/languages.js:48)
    at Object.next (/Users/akos.kitta/gi…gin/languages.js:29)
    at /Users/akos.kitta/gi…gin/languages.js:23
    at new Promise (<anonymous>)
    at errors.ts:26

I got this once when I reloaded the browser example: (I assume this is unrelated to vscode.CustomExecution)

root ERROR Could not transfer 'README.md' file from 'redhat_java' Error: Request aborted
    at onaborted (/Users/akos.kitta/git/theia/node_modules/express/lib/response.js:1025:15)
    at Immediate.<anonymous> (/Users/akos.kitta/git/theia/node_modules/express/lib/response.js:1067:9)
    at processImmediate (internal/timers.js:439:21)
root ERROR Could not transfer 'README.md' file from 'richardwillis_vscode_gradle' Error: Request aborted
    at onaborted (/Users/akos.kitta/git/theia/node_modules/express/lib/response.js:1025:15)
    at Immediate.<anonymous> (/Users/akos.kitta/git/theia/node_modules/express/lib/response.js:1067:9)
    at processImmediate (internal/timers.js:439:21)

There was some issue with OVSX when I started the app: (Seems to be unrelated to this PR)

root ERROR [foo-bar.task-provider-samples]: failed to refresh, reason: Error: Extension with id foo-bar.task-provider-samples not found at https://open-vsx.org/api
    at VSXRegistryAPI.<anonymous> (http://localhost:3000/71.bundle.js:3165:31)
    at step (http://localhost:3000/71.bundle.js:3020:23)
    at Object.next (http://localhost:3000/71.bundle.js:3001:53)
    at fulfilled (http://localhost:3000/71.bundle.js:2992:58)

Signed-off-by: Lewin Tan <[email protected]>

shyshywhy · 2021-04-02T10:31:26Z

@shyshywhy do you mind rebasing the pull-request against the latest master? There are some changes which will be required due to the re-export pull-request: #9124.

ok，its done.

RomanNikitenko · 2021-04-09T08:08:20Z

packages/task/src/node/task-server.ts

@@ -89,7 +90,7 @@ export class TaskServerImpl implements TaskServer, Disposable {
    }

    async run(taskConfiguration: TaskConfiguration, ctx?: string, option?: RunTaskOption): Promise<TaskInfo> {
-        const runner = this.runnerRegistry.getRunner(taskConfiguration.type);
+        const runner = this.runnerRegistry.getRunner(taskConfiguration.taskType);


@shyshywhy
could you share the reason why type was replaced by taskType?

vince-fugnitto · 2021-04-16T13:25:44Z

The commit seems to have broken a lot of functionality from tasks, should we revert for the time being?

https://github.com/eclipse-theia/theia/blob/master/doc/pull-requests.md#reverting-pr

If a PR causes regressions after landing then an author and maintainers have 2 days to resolve them after that a PR has to be reverted.

If the issues are not resolved before the release I think we should revert as to not release a broken task system.

tsmaeder · 2021-04-16T13:39:42Z

@vince-fugnitto So what breakage is left?

vince-fugnitto · 2021-04-16T13:41:33Z

@vince-fugnitto So what breakage is left?

I see the following for the moment (possibly others):

RomanNikitenko · 2021-04-16T13:44:20Z

#9341

azatsarynnyy · 2021-04-16T14:03:29Z

I fully agree with Vincent. It should be reverted according to our PR policy. As the PR originator hasn't responded for a week.

RomanNikitenko · 2021-04-16T14:04:32Z

I'm not able to take in progress any issue from the list above soon, so I'm +1 for reverting...

azatsarynnyy · 2021-04-16T14:08:38Z

I fully agree with Vincent. It should be reverted according to our PR policy. As the PR originator hasn't responded for a week.

unless someone else is going to fix all the breakages before the release

azatsarynnyy · 2021-04-16T14:20:22Z

On the other hand, we have almost two weeks before the release date...
So, I see two choices here:

revert the PR
or get the concrete assignees for all the issues found, who could help to fix all of them

tsmaeder · 2021-04-16T14:24:31Z

I think we all agree this PR should not have been merged. The question now is what the way forward should be. Personally, I think we (probably me, since I already have a head start) should fix the issues, The PR was not huge and I think we could fix the issues in question within maybe 2 days. At least invest a couple of hours to see what the problem is before throwing out the feature.

vince-fugnitto · 2021-04-16T14:26:22Z

I think we all agree this PR should not have been merged. The question now is what the way forward should be. Personally, I think we (probably me, since I already have a head start) should fix the issues, The PR was not huge and I think we could fix the issues in question within maybe 2 days. At least invest a couple of hours to see what the problem is before throwing out the feature.

@tsmaeder since we have time before the release I think we can spend time to fix the regressions, and if ever we see that we run out of time, or there are too many regressions for the framework to be released we can think of reverting.

tsmaeder · 2021-04-16T14:30:56Z

Sounds like a plan!

RomanNikitenko · 2021-04-16T14:49:54Z

Great!
I can help with testing :-)

alvsan09 · 2021-04-19T01:11:11Z

The PR #9189 merged 5 commits to support the Tasks customExecution API,
one of the commits ("Fixed task type is modified") is the one that has caused cascading issues related to task type,
The PR #9373, removes only that particular problematic commit and two other trying to work around the main issue.

The good part is that removing that particular commit does not remove the support for customExecution,
the impacted scenario is #8767 where gradle tasks are not visible.

if we consider PR #9373 as a good base, we can then concentrate on fixing #8767.

shyshywhy mentioned this pull request Mar 12, 2021

support vscode.CustomExecution api #7185

Closed

tsmaeder requested a review from RomanNikitenko March 12, 2021 08:03

kittaakos self-requested a review March 12, 2021 08:08

shyshywhy force-pushed the ft/support_custom_execution branch 4 times, most recently from bd7555f to 3fe0ad7 Compare March 14, 2021 03:38

vince-fugnitto added the vscode issues related to VSCode compatibility label Mar 15, 2021

vince-fugnitto reviewed Mar 15, 2021

View reviewed changes

packages/task/src/node/custom/custom-task-runner-backend-module.ts Outdated Show resolved Hide resolved

packages/task/src/node/custom/custom-task-runner.ts Outdated Show resolved Hide resolved

packages/terminal/src/browser/terminal-widget-impl.ts Show resolved Hide resolved

kittaakos reviewed Mar 16, 2021

View reviewed changes

packages/task/src/node/custom/custom-task.ts Outdated Show resolved Hide resolved

shyshywhy force-pushed the ft/support_custom_execution branch from 8bdeba3 to 98e9348 Compare March 17, 2021 09:40

shyshywhy requested review from kittaakos and vince-fugnitto March 22, 2021 03:08

shyshywhy added 2 commits April 2, 2021 18:28

Fix task type is modified.

421b08a

Signed-off-by: Lewin Tan <[email protected]>

Support re-export for custom task.

0d03021

Signed-off-by: Lewin Tan <[email protected]>

shyshywhy force-pushed the ft/support_custom_execution branch from 80725c2 to 0d03021 Compare April 2, 2021 10:29

kittaakos merged commit fd91f21 into eclipse-theia:master Apr 6, 2021

vince-fugnitto added this to the 1.13.0 milestone Apr 6, 2021

shyshywhy deleted the ft/support_custom_execution branch April 7, 2021 02:17

RomanNikitenko reviewed Apr 9, 2021

View reviewed changes

tsmaeder mentioned this pull request Apr 13, 2021

TaskRunner Registration is broken #9334

Closed

This was referenced Apr 13, 2021

Cannot execute npm Task #9335

Closed

Task type is not displayed for detected tasks #9341

Open

Resolving variables for tasks is not working anymore #9351

Closed

paul-marechal mentioned this pull request Apr 14, 2021

tasks: properly type task.taskType? #9357

Closed

RomanNikitenko mentioned this pull request Apr 16, 2021

Configuring tasks are broken #9365

Open

vince-fugnitto mentioned this pull request Apr 16, 2021

task: unable to run provided tasks #9366

Closed

alvsan09 mentioned this pull request Apr 19, 2021

Revert task types updates #9373

Closed

1 task

tsmaeder mentioned this pull request Apr 20, 2021

Clean up handling of 'taskType' field #9377

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement CustomExecution extension API #9189

Implement CustomExecution extension API #9189

shyshywhy commented Mar 12, 2021 •

edited by vince-fugnitto

Loading

shyshywhy commented Mar 12, 2021

azatsarynnyy commented Mar 12, 2021

shyshywhy commented Mar 14, 2021

kittaakos commented Mar 15, 2021

kittaakos commented Mar 16, 2021

shyshywhy commented Mar 16, 2021

kittaakos commented Mar 16, 2021

shyshywhy commented Mar 17, 2021

kittaakos commented Mar 23, 2021

kittaakos commented Mar 23, 2021

kittaakos commented Mar 23, 2021

kittaakos commented Mar 23, 2021

shyshywhy commented Mar 26, 2021

shyshywhy commented Mar 26, 2021

kittaakos commented Mar 30, 2021

kittaakos commented Mar 30, 2021

shyshywhy commented Apr 2, 2021

RomanNikitenko Apr 9, 2021

vince-fugnitto commented Apr 16, 2021

tsmaeder commented Apr 16, 2021

vince-fugnitto commented Apr 16, 2021

RomanNikitenko commented Apr 16, 2021

azatsarynnyy commented Apr 16, 2021

RomanNikitenko commented Apr 16, 2021 •

edited

Loading

azatsarynnyy commented Apr 16, 2021

azatsarynnyy commented Apr 16, 2021

tsmaeder commented Apr 16, 2021

vince-fugnitto commented Apr 16, 2021

tsmaeder commented Apr 16, 2021

RomanNikitenko commented Apr 16, 2021

alvsan09 commented Apr 19, 2021

Implement CustomExecution extension API #9189

Implement CustomExecution extension API #9189

Conversation

shyshywhy commented Mar 12, 2021 • edited by vince-fugnitto Loading

What it does

How to test

Review checklist

Reminder for reviewers

shyshywhy commented Mar 12, 2021

azatsarynnyy commented Mar 12, 2021

shyshywhy commented Mar 14, 2021

kittaakos commented Mar 15, 2021

kittaakos commented Mar 16, 2021

shyshywhy commented Mar 16, 2021

kittaakos commented Mar 16, 2021

shyshywhy commented Mar 17, 2021

kittaakos commented Mar 23, 2021

kittaakos commented Mar 23, 2021

kittaakos commented Mar 23, 2021

kittaakos commented Mar 23, 2021

shyshywhy commented Mar 26, 2021

shyshywhy commented Mar 26, 2021

kittaakos commented Mar 30, 2021

kittaakos commented Mar 30, 2021

shyshywhy commented Apr 2, 2021

RomanNikitenko Apr 9, 2021

Choose a reason for hiding this comment

vince-fugnitto commented Apr 16, 2021

tsmaeder commented Apr 16, 2021

vince-fugnitto commented Apr 16, 2021

RomanNikitenko commented Apr 16, 2021

azatsarynnyy commented Apr 16, 2021

RomanNikitenko commented Apr 16, 2021 • edited Loading

azatsarynnyy commented Apr 16, 2021

azatsarynnyy commented Apr 16, 2021

tsmaeder commented Apr 16, 2021

vince-fugnitto commented Apr 16, 2021

tsmaeder commented Apr 16, 2021

RomanNikitenko commented Apr 16, 2021

alvsan09 commented Apr 19, 2021

shyshywhy commented Mar 12, 2021 •

edited by vince-fugnitto

Loading

RomanNikitenko commented Apr 16, 2021 •

edited

Loading