core: lazy preference proxy #9169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
preferences
|
cc @dukengn |
|
My approach is to keep returning proxies synchronously so that they can be bound using Inversify, but the the returned proxy will perform no-ops until the schema is resolved. |
It is possible to register a preference schema to the `PreferenceSchemaProvider` after the initial inversify binding phase. This is problematic when wanting to do that late schema registration and at the same time trying to bind a preference proxy because proxies must be bound early on. This commit fixes the issue by allowing `createPreferenceProxy` to process a promise for its `schema` parameter (now `promisedSchema`) and still return a proxy synchronously. Until the promise resolves, most operations on the proxy will be no-ops. Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/lazy-preference-proxy
branch
from
b9344a9 to
e8df8a6
Compare
3 tasks
vince-fugnitto
approved these changes
Mar 12, 2021
DucNgn
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to register a preference schema to the
PreferenceSchemaProviderafter the initial inversify binding phase.This is problematic when wanting to do that late schema registration and
at the same time trying to bind a preference proxy because proxies must
be bound early on.
This commit fixes the issue by allowing
createPreferenceProxytoprocess a promise for its
schemaparameter (nowpromisedSchema) andstill return a proxy synchronously. Until the promise resolves, most
operations on the proxy will be no-ops.
How to test
See added tests.
Review checklist
Reminder for reviewers