monaco: fix gutter size due to lineNumbers #9168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
editor
The following commit updates the default `lineNumbersMinChars` similarly to vscode in order to produce a more appropriate gutter size (lineNumber size) in the editor. Reducing the size means that we can improve the readability of the code rather than have excessive gutters. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/editor-gutter
branch
from
77e85bd to
9b94daa
Compare
RomanNikitenko
approved these changes
Mar 10, 2021
DucNgn
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #5397
The following commit updates the default
lineNumbersMinCharssimilarly to vscode in order to produce a more appropriate gutter size (lineNumber size) in the editor. Reducing the size means that we can improve the readability of the code rather than have excessive gutters.vscode reference.
How to test
tsfileReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]