Fix vscode.window.createTerminal with cwd

[veredcon]

Signed-off-by: Vered Constantin [email protected]

Fix #7586

With this PR, creating terminal with cwd option will make sure the cwd is a string as it should be.
(As specified in TerminalWidgetOptions.cwd )

What it does

It makes the createTerminal API more robust even in case the cwd passed by extensions is URI (like happens with vscode-maven extension). VScode still works fine even when extension is passing URI as cwd to this API.

How to test

Explained in #7586:

1. Install vscode-maven, all versions starting from https://open-vsx.org/api/vscjava/vscode-maven/0.21.2/file/vscjava.vscode-maven-0.21.2.vsix
2. Click on the project context menu: clean/install etc.

Expected Result:
A terminal should be opened with the corresponding command being executed in the terminal

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[kittaakos]

It looks good to me. Thank you for the patch, @veredcon 👍

---

@vince-fugnitto, could you please proceed with the merge if you're also fine with the PR? Thank you!

[veredcon]

@kittaakos thanks for the quick review!
seems like some test not related to this change fails in ubuntu?... I noticed this in the logs:
log-level-cli-contribution
@theia/core: should read json config file:
@theia/core: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/theia/theia/packages/core/lib/node/logger-cli-contribution.spec.js)

are you familiar with this? I cannot also retrigger

[vince-fugnitto]

@veredcon I believe the CI was failing since it may not be based on the latest master, but it should not be an issue (I restarted the build anyways).