Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Debugging Plugin Sources' in Developing.md #9018

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

alvsan09
Copy link
Contributor

@alvsan09 alvsan09 commented Feb 1, 2021

Added guidelines on how to debug a vscode extension as a
Theia plugin from sources.

Signed-off-by: Alvaro Sanchez-Leon [email protected]

What it does

Adds guidelines on how to debug a vscode extension as a
Theia plugin from sources.

How to test

The source can be downloaded and the impacted file opened with an mark down editor for a proper review

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added debug issues that related to debug functionality documentation issues related to documentation plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Feb 2, 2021
doc/Developing.md Outdated Show resolved Hide resolved
doc/Developing.md Outdated Show resolved Hide resolved
Added guidelines on how to best debug a vscode extension as a
Theia plugin from sources.

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alvsan09 I forced pushed the last few formatting issues I saw, LGTM now!

@alvsan09
Copy link
Contributor Author

alvsan09 commented Feb 3, 2021

It looks good to me as well, Thanks @marechal-p !

@paul-marechal paul-marechal merged commit 9f7993d into eclipse-theia:master Feb 3, 2021
@paul-marechal paul-marechal added this to the 1.11.0 milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality documentation issues related to documentation plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants