Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #7556 turn "Language for 'X' not found" to warnings #8938

Merged
merged 1 commit into from
Jan 18, 2021
Merged

fix issue #7556 turn "Language for 'X' not found" to warnings #8938

merged 1 commit into from
Jan 18, 2021

Conversation

ronabet
Copy link

@ronabet ronabet commented Jan 12, 2021 •
edited
Loading

Signed-off-by: Ron Nabet [email protected]

What it does

Fixes #7556

Converts all errors from the same built-in extension (languages) to warnings.

How to test

Start Theia from master.

Review checklist

Reminder for reviewers

@amiramw
Copy link
Member

amiramw commented Jan 12, 2021

why is the grouping to array needed?

@ronabet ronabet changed the title fix for #755 fix for #7556 issue Jan 12, 2021
@ronabet
Copy link
Author

ronabet commented Jan 12, 2021

why is the grouping to array needed?

In order to connect all the errors to one string (warning).

@amiramw
Copy link
Member

amiramw commented Jan 12, 2021

In order to connect all the errors to one string (warning).

why do they need to be in one string? can't there be several warnings?

@ronabet
Copy link
Author

ronabet commented Jan 12, 2021

In order to connect all the errors to one string (warning).

why do they need to be in one string? can't there be several warnings?

also a possibility, @akosyakov offered to report them once.

@amiramw
Copy link
Member

amiramw commented Jan 12, 2021

also a possibility, @akosyakov offered to report them once.

I would prefer to just change error to warning and avoid extra complexity

@ronabet
Copy link
Author

ronabet commented Jan 13, 2021

also a possibility, @akosyakov offered to report them once.

I would prefer to just change error to warning and avoid extra complexity

updated

@ronabet ronabet requested a review from amiramw January 14, 2021 08:27
@amiramw
Copy link
Member

amiramw commented Jan 14, 2021

@ronabet please change your commit subject/description to something that explain what it does and not only to have the issue id

@amiramw amiramw changed the title fix for #7556 issue fix issue #7556 turn "Language for 'X' not found" to warnings Jan 17, 2021
amiramw
amiramw approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@amiramw amiramw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and "Language for 'X' not found" are now logged as warnings

@amiramw amiramw merged commit b6add4a into eclipse-theia:master Jan 18, 2021
@ronabet ronabet deleted the 7556 branch January 31, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiramw amiramw amiramw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser console errors: Language for 'X' not found.
2 participants
@ronabet @amiramw