Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't activate plugin eagerly on unsupported event #8396

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 17, 2020

What it does

When we did not support many activation events it was useful to activate some extensions eagerly. But by now we support most popular and remaining either secondary or lead to bad experience like missing support of native notebooks or custom editors. This PR does not activate extensions eagerly anymore to prevent such effects.

How to test

  • Start a fresh Theia, don nothing but install python extension from Extensions view.
  • Check that after installation python extension is not activated, but you see that some events are logged as unsupported in the backend log.
  • Now open python file or create a new notebook. At this moment the python extension should activate, enable features and show the welcome page.
  • Close everything and reload the page.
  • Again open python file or new notebook. This time the python extension should activate, enable features, but welcome page should not be shown.

Review checklist

Reminder for reviewers

@akosyakov akosyakov added python issues related to the python language / extension vscode issues related to VSCode compatibility labels Aug 17, 2020
@akosyakov akosyakov force-pushed the akosyakov/latest-python-extension-8394 branch from aa1776b to d4176d9 Compare August 17, 2020 14:20
@akosyakov akosyakov merged commit 3616b0a into master Aug 18, 2020
@akosyakov akosyakov deleted the akosyakov/latest-python-extension-8394 branch August 18, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python issues related to the python language / extension vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest python extension is activated always
2 participants