don't activate plugin eagerly on unsupported event #8396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When we did not support many activation events it was useful to activate some extensions eagerly. But by now we support most popular and remaining either secondary or lead to bad experience like missing support of native notebooks or custom editors. This PR does not activate extensions eagerly anymore to prevent such effects.
How to test
Extensions
view.Review checklist
Reminder for reviewers