Electron main fixup #8069
Closed
Electron main fixup #8069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The vs code built in extension `npm` does not work with Theia's plugin extension due to not being able to find the constructor of `Task2`. This pull request addes the missing constructor, and upgrades the version of `npm` in Theia. Signed-off-by: Liang Huang <[email protected]>
- In VS Code a `detail` property can be added to the contributed and configured tasks. The content of that `detail` property is displayed as part of the task quick open menu items. With changes in this commit, `detail` is added to the task config schema. Signed-off-by: Liang Huang <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Vladyslav Zhukovskyi <[email protected]>
`--sort=commiterdate` behaves differently with `2.27.0.windows.1`. Signed-off-by: Akos Kitta <[email protected]>
Fixes: #7979 Added a `Clear-All` toolbar item, which clears all the existing problem markers Signed-off-by: Anas Shahid <[email protected]>
editor.maxTokenizationLineLength default value changed back to 400, the value 20000 like in VS Code breaks on browser and some electrons when opening minified files. Signed-off-by: João Gaião <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Mikael Desharnais <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Anton Kosyakov <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
solves race condition that happens when there are several consecutive calls to saveContentChanges. since before this fix, version was passed to isInSync before asynchronously calling getFileStat there were times when it was old on the sync check but current on this.version. then onDidChangeContentsEmitter.fire was called wrongly Signed-off-by: Amiram Wingarten <[email protected]>
Fixes: #8053 The following commit updates the `download:plugins` script to report when the mandatory `theiaPlugins` property is missing from the `package.json` resulting in no plugins being downloaded. Signed-off-by: vince-fugnitto <[email protected]>
Signed-off-by: Kenneth Marut <[email protected]>
The Contextmenu was not showing the option to clear the Output, because seperate Commands for the toolbar and contextmenu are required. Signed-off-by: Jan-Niklas Spangenberg <[email protected]>
kittaakos
force-pushed
the
electron-main-fixup
branch
from
1eceab6 to
d200927
Compare
|
@marechal-p, I have fixed and restored the
Since your previous review was positive, I am hoping for no further changes here. Any remarks? Thanks! |
kittaakos
force-pushed
the
electron-main-fixup
branch
from
d200927 to
186adb8
Compare
1 task
Fixes: #8016 The following pull-request updates the plugin system to include the registration of `view containers` in the `open view` prefix menu. Signed-off-by: vince-fugnitto <[email protected]>
Signed-off-by: Colin Grant <[email protected]>
The following pull-request updates the `preferences` modified scope message to display messages in the `user` tab when there are updates to the preference in the `workspace` scope. Signed-off-by: vince-fugnitto <[email protected]>
paul-marechal
force-pushed
the
electron-main-fixup
branch
4 times, most recently
from
d71cef3 to
3c82aa0
Compare
paul-marechal
force-pushed
the
electron-main-fixup
branch
from
3c82aa0 to
2ff0ede
Compare
All the logic for the electron main process currently has to be added to our generators, making it hard to extend without committing to Theia. This commit re-arranges the way Electron is launched to allow people to more easily change the behavior of their application. Add a basic CLI to open a workspace by doing `app path/to/workspace`. CLI can be overriden by application makers by extending and rebinding `ElectronApplication.launch` and handling yourself the `ExecutionParams`. Signed-off-by: Paul Maréchal <[email protected]> Co-Authored-By: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
paul-marechal
force-pushed
the
electron-main-fixup
branch
from
2ff0ede to
f875177
Compare
|
Ok the rebase did something weird, I will fix this. |
|
Oh no ok this is the wrong PR I was looking at, I will close this now. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marechal-p, this PR proposes a few changes to your electron-main PR and adds an updater example. I have dropped thefileargument support; it does not work on macOS.What it does
How to test
Review checklist
Reminder for reviewers