scm: add 'scm.defaultViewMode' preference #7717
Conversation
vince-fugnitto
added
preferences
|
@westbury internally I kept |
vince-fugnitto
force-pushed
the
vf/scm-preferences
branch
from
82f4c0a to
654aca6
Compare
added the preference `scm.defaultViewMode` which controls the view mode rendering of the scm widget from tree to flat list. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/scm-preferences
branch
from
654aca6 to
c9b88e2
Compare
There was a problem hiding this comment.
I have tested it and it works great. Thanks. I'm impressed that changing the preference even changes views that are already open.
BTW, sorry earlier I commented on code without first reading the full PR. I didn't see your PR comment until later. I'll be more careful to read the PR before commenting on code linked to in the e-mail. Thanks for worrying about breaking Arm but actually it is a lot of work for us to upgrade Theia and a change like that would be trivial for us.
Thank you for the review and no problem! :) |
|
@vince-fugnitto is it ok if I merge this? The reason I ask is that I have another PR that would conflict with this one. |
Yes go ahead! |
|
@westbury I merged for you, thank you for the review :) |
What it does
Fixes: #7713
The following pull-request adds a new preference for the scm extension named
scm.defaultViewMode which is used to control the view mode rendering of the scm widget between displaying results as a tree or a flat list.
scm.defaultViewMode: list
scm.defaultViewMode: tree
How to test
(the scm widget's view mode should update accordingly)
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]