plugins: update download script to include colors #7648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
approved these changes
Apr 22, 2020
Skipped is with the default terminal color, not white. |
Yes that's what I meant 🙈In my terminal it just so happens to be white. |
The commit updates the logging performed by the `download:script`: - green: download successful. - red: errors or could not download plugin. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/download-plugins-colored
branch
from
dd3fa24 to
9c6b54b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The commit updates the logging performed by the
download:scriptby coloring the output so it is more visible and also updates the error message to be more descriptive:How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]