Change successExitCodes and ExpectedErrors to arrays #7627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Signed-off-by: Nigel Westbury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both successExitCodes and ExpectedErrors Git options are sets. However the interface is serializable so objects cannot be used here. This breaks frontend code that uses either of these options.
What it does
These two options are changed to arrays. They are converted to sets in the backend before passing on to Dugite.
How to test
Check the existing places that use these options. Currently these options are only set in the backend. If you need to test that the arrays can be set from the frontend, I can ask a colleague to test or I can make up some test code.
Review checklist
Reminder for reviewers