Fix: Keybindings on Numpad special keys (#7315)

[geropl]

Fixes #7315.

This adds an exception to KeyCode.toKey regarding special keys on numpads

Signed-off-by: Gero Posmyk-Leinemann [email protected]

What it does

This adds an exception for Numpad keys during the KeyboardEvent -> key bindings resolution. It ensures that with Numlock disabled, special keys like HOME (on Numpad7), END (on Numpad1) etc. are detected and handled correctly.

How to test

• Open a regular editor
• ensure that Numlock is disabled
• press Numpad7 (HOME), Numpad1 (END), Numpad9 (Page Up), Numpad3 (Page Down`) and observe the respective cursor movement

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[geropl]

@spoenemann @akosyakov Can you have a look? Thanks!

[akosyakov]

@geropl you have to sign ECA: https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md#eclipse-contributor-agreement

[spoenemann]

I cannot test it with my keyboard, but the change makes sense to me.

[paul-marechal]

Should we really use keyCode though? MDN shows it as deprecated.

I tested with https://w3c.github.io/uievents/tools/key-event-viewer.html:

event.key seems to map to the same key representation, when event.code maps to the layout-independent identifier (see 1-and-2 vs 1-and-4)

[geropl]

Should we really use keyCode though? MDN shows it as deprecated.

@marechal-p Oh, that's news to me, thx. Switched to .key 👆 , still works nicely.

[paul-marechal]

Works well, thanks!

[akosyakov]

@spoenemann are you fine with changes, please merge if so

[spoenemann]

Switched to .key 👆 , still works nicely.

Note that key takes modifiers into account. @geropl could you check whether pressing the numpad keys with any combination of shift, ctrl, alt leads to the same key value?

https://w3c.github.io/uievents/tools/key-event-viewer.html

[geropl]

@spoenemann key stays the same, irregardless of the modifiers:

(with alt it works as well but is hard to show because alt + home sets the current tab to "Home")

[spoenemann]

Does it work also when Numlock is enabled? In that case key is just a string with a number, and we don't have any mapping for that in Key.getKey.

IMO it would be safer to switch back to keyCode.

[geropl]

@spoenemann and I found out that Shift + Numlock + Numpad7 resolves to 7 (on Linux), so we stay with .key which does the same.

We narrowed the corner case to "complex numpad keys" by adding the check for && event.key.length > 1.