electron: use timingSafeEqual to check token #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phosphore Would this make the token comparison safer? |
phosphore
approved these changes
Mar 10, 2020
vince-fugnitto
approved these changes
Mar 10, 2020
paul-marechal
force-pushed
the
mp/electron-token-safe
branch
3 times, most recently
from
871365c to
efc12b1
Compare
marcdumais-work
approved these changes
Mar 11, 2020
This should prevent an attacker from guessing the Electron token via a timing attack to access an Electron application's local backend services. timingSafeEqual: https://nodejs.org/docs/latest-v10.x/api/crypto.html#crypto_crypto_timingsafeequal_a_b Timing Attack: https://en.wikipedia.org/wiki/Timing_attack Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/electron-token-safe
branch
from
efc12b1 to
d9d15b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent an attacker from guessing the Electron token to
access an Electron application's local backend services.
Signed-off-by: Paul Maréchal [email protected]
What it does
Better safe than sorry, this PR addresses a comment made on the token implementation: #7205 (comment)
How to test
Hard to say, it would require trying to execute a purposeful timing attack, which I don't know how to do.
Review checklist
Reminder for reviewers