Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prepare-travis): Always use JSON output of the yarn workspaces command #7119

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 10, 2020

What it does

With yarn v1.22.0 the output is not rendered in JSON when it's the last parameter
Fixes #7118

How to test

bump to yarn v1.22.0

Review checklist

Reminder for reviewers

Change-Id: I98a0d59a98e3e3226cbc242c1a5e264aaa6fd607
Signed-off-by: Florent Benoit [email protected]

With yarn v1.22.0 the output is not rendered in JSON when it's the last parameter

Change-Id: I98a0d59a98e3e3226cbc242c1a5e264aaa6fd607
Signed-off-by: Florent Benoit <[email protected]>
@benoitf benoitf changed the title fix(prepare-travis): Always use JSON output of the command fix(prepare-travis): Always use JSON output of the yarn workspaces command Feb 10, 2020
@akosyakov
Copy link
Member

Does it work with yarn 1.21?

@akosyakov akosyakov added the ci issues related to CI / tests label Feb 10, 2020
@benoitf
Copy link
Contributor Author

benoitf commented Feb 10, 2020

@akosyakov yes

@benoitf
Copy link
Contributor Author

benoitf commented Feb 10, 2020

@akosyakov also seems to work with

$ yarn --version
1.15.2

used on CI

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@benoitf
Copy link
Contributor Author

benoitf commented Feb 11, 2020

If no more feedback today, will merge it.

@akosyakov
Copy link
Member

@benoitf please do 👍

@benoitf benoitf merged commit e7b7a2b into eclipse-theia:master Feb 11, 2020
@benoitf benoitf deleted the THEIA-7118 branch February 11, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build with Yarn v1.22.0
2 participants