Add ability to handle vscode.openFolder command #6928
Conversation
Signed-off-by: Tomer Epstein <[email protected]>
akosyakov
requested review from
azatsarynnyy,
benoitf,
vince-fugnitto and
amiramw
| @@ -101,6 +108,20 @@ export class PluginVscodeCommandsContribution implements CommandContribution { | |||
| } | |||
| }); | |||
|
|
|||
| commands.registerCommand(VscodeCommands.OPEN_FOLDER, { | |||
| isVisible: () => false, | |||
| execute: async (resource?: URI, options?: WorkspaceInput | undefined) => { | |||
There was a problem hiding this comment.
I'm not suer about WorkspaceInput.
We should use VS Code type definition for options and translate it to WorkspaceInput. Could you look up the relevant code in VS Code?
There was a problem hiding this comment.
Signed-off-by: Tomer Epstein <[email protected]>
Signed-off-by: Tomer Epstein <[email protected]>
|
@akosyakov i'm confused with regard to git pod workspace created in this PR. When I login and open chrome dev tools I don't see the changes. Is there something wrong with the CI or I am missing something? |
|
@amiramw , try this:
|
|
@amiramw When you log in you see Gitpod Theia, not Theia from the PR. There should be a notification to open a Theia from the PR, or you can open it from the port view as @tomer-epstein pointed out |
|
@amiramw Could you finish the review? If it works then let's merge, code wise it looks good to me. |
|
Tested successfully and code looks good to me. |
|
@amiramw @tomer-epstein please check the git history next time, there are 3 commits in this PR for one file change :( https://github.com/eclipse-theia/theia/blob/master/doc/pull-requests.md#checklist-commit-history |
|
@akosyakov can you pls update #4050 |
Sorry. I missed that. |
Signed-off-by: Tomer Epstein [email protected]
Issue: #4050
What it does
This change proposal adds ability to handle vscode.openFolder command.
How to test
Review checklist
Reminder for reviewers