GH-1614, GH-4532: Various dev experience enhancements for win32 #6893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2020 18:41
Got rid of `choco` and simplified the steps with `scoop`. The steps now include headless commands for installing the followings: - `nvm`, - Node.js, - `yarn`, and optionally - `git`. Closes #1614 Signed-off-by: Akos Kitta <[email protected]>
So `webpack` does not try to detect module cycles under `node_modules`. Signed-off-by: Akos Kitta <[email protected]>
- Aug 7, 2017: The parallel execution was bugusly introduced: e8beacc. - Nov 9, 2018: The logic was fixed: 5a60919. `lerna` ran perfecetly without the sequential restriction for a year. No need to punish Windows users with this build penalty. This commit reverts e8beacc. Closes #4532 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
added
OS/Windows
See, no more |
kittaakos
changed the title
|
Pinging @marechal-p since he has a Windows machine to test on 😃 |
|
By the way, here are some performance numbers for the build (
|
paul-marechal
approved these changes
Jan 17, 2020
|
Ah, pinged Rob since I know Mbed Studio is an electron app on Windows, might not really impact his team though. Feel free to wait or merge. |
|
Thanks @marechal-p We use a separate set of scripts to build, so this is unlikely to impact. Likely we can steal some of the ideas, though :) Please go ahead and merge. @westbury @mcgordonite Is there anything in here which can help with Windows build speed? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
lernaexecution on Windows (closes [dev-experience][windows] Investigate whether we can enable parallel execution with Lerna #4532),Please read the individual commit messages for more details or ask.
How to test
The CI should test it.
Review checklist
Reminder for reviewers