[merge-conflicts] fix 'merge-conflicts' command category #6790
Conversation
- fixed the typo present in the command category prefix. - made the command prefix exportable so it can be resued by others. Signed-off-by: Vincent Fugnitto <[email protected]>
| @@ -35,20 +35,20 @@ export interface MergeConflictCommandArgument { | |||
| } | |||
|
|
|||
| export namespace MergeConflictsCommands { | |||
| const MERGE_CONFLIC_PREFIX = 'Merge Conflict'; | |||
| export const MERGE_CONFLICT_PREFIX = 'Merge Conflict'; | |||
There was a problem hiding this comment.
Why do we need to export this one?
There was a problem hiding this comment.
I included the export so that others (extenders) would be able to access the prefix and be able to categorize their commands with existing ones if they wanted to. Do you believe we should not export?
There was a problem hiding this comment.
ah ok maybe you would have another PR where MERGE_CONFLICT_PREFIX is referenced ?
There was a problem hiding this comment.
Exactly, let's say I'm an extender who wishes to use the prefix because they are contributing commands to the same category. Before the pull request, they'd have to duplicate and hard code the value while if it is exported they can simply reference it.
Thank you @elaihau! |
What it does
How to test
@theia/merge-conflicts(build & tests)Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]