Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug] fix typos present in 'debug' extension #6698

Merged
merged 1 commit into from
Dec 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Breaking changes:

- [core] new browser windows spawned through opener-service have noopener set, preventing them from accessing window.opener and giving them their own event loop. openNewWindow will no longer return a Window as a result.
- [terminal] renamed `TerminalCopyOnSelectionHander` to `TerminalCopyOnSelectionHandler` [#6692](https://github.com/eclipse-theia/theia/pull/6692)
- [debug] renamed command `COPY_VARAIBLE_AS_EXPRESSION` to `COPY_VARIABLE_AS_EXPRESSION` [#6698](https://github.com/eclipse-theia/theia/pull/6698)
- [debug] renamed command `COPY_VARAIBLE_VALUE` to `COPY_VARIABLE_VALUE` [#6698](https://github.com/eclipse-theia/theia/pull/6698)
- [debug] renamed getter method `multiSesssion` to `multiSession` [#6698](https://github.com/eclipse-theia/theia/pull/6698)

## v0.13.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,12 @@ export namespace DebugCommands {
category: DEBUG_CATEGORY,
label: 'Set Value',
};
export const COPY_VAIRABLE_VALUE: Command = {
export const COPY_VARIABLE_VALUE: Command = {
id: 'debug.variable.copyValue',
category: DEBUG_CATEGORY,
label: 'Copy Value',
};
export const COPY_VAIRABLE_AS_EXPRESSION: Command = {
export const COPY_VARIABLE_AS_EXPRESSION: Command = {
id: 'debug.variable.copyAsExpression',
category: DEBUG_CATEGORY,
label: 'Copy As Expression',
Expand Down Expand Up @@ -477,8 +477,8 @@ export class DebugFrontendApplicationContribution extends AbstractViewContributi

registerMenuActions(DebugVariablesWidget.CONTEXT_MENU,
DebugCommands.SET_VARIABLE_VALUE,
DebugCommands.COPY_VAIRABLE_VALUE,
DebugCommands.COPY_VAIRABLE_AS_EXPRESSION
DebugCommands.COPY_VARIABLE_VALUE,
DebugCommands.COPY_VARIABLE_AS_EXPRESSION
);

registerMenuActions(DebugBreakpointsWidget.EDIT_MENU,
Expand Down Expand Up @@ -737,12 +737,12 @@ export class DebugFrontendApplicationContribution extends AbstractViewContributi
isEnabled: () => !!this.selectedVariable && this.selectedVariable.supportSetVariable,
isVisible: () => !!this.selectedVariable && this.selectedVariable.supportSetVariable
});
registry.registerCommand(DebugCommands.COPY_VAIRABLE_VALUE, {
registry.registerCommand(DebugCommands.COPY_VARIABLE_VALUE, {
execute: () => this.selectedVariable && this.selectedVariable.copyValue(),
isEnabled: () => !!this.selectedVariable && this.selectedVariable.supportCopyValue,
isVisible: () => !!this.selectedVariable && this.selectedVariable.supportCopyValue
});
registry.registerCommand(DebugCommands.COPY_VAIRABLE_AS_EXPRESSION, {
registry.registerCommand(DebugCommands.COPY_VARIABLE_AS_EXPRESSION, {
execute: () => this.selectedVariable && this.selectedVariable.copyAsExpression(),
isEnabled: () => !!this.selectedVariable && this.selectedVariable.supportCopyAsExpression,
isVisible: () => !!this.selectedVariable && this.selectedVariable.supportCopyAsExpression
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ describe('Launch Preferences', () => {
assert.deepStrictEqual(JSON.parse(JSON.stringify(config)), expectation);
});

testIt('get from undefind', () => {
testIt('get from undefined', () => {
const config = preferences.get('launch', undefined, undefined);
assert.deepStrictEqual(JSON.parse(JSON.stringify(config)), expectation);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/browser/view/debug-threads-source.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class DebugThreadsSource extends TreeSource {
this.toDispose.push(this.model.onDidChange(() => this.fireDidChange()));
}

get multiSesssion(): boolean {
get multiSession(): boolean {
return this.model.sessionCount > 1;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/browser/view/debug-threads-widget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class DebugThreadsWidget extends SourceTreeWidget {
}

protected getDefaultNodeStyle(node: TreeNode, props: NodeProps): React.CSSProperties | undefined {
if (this.threads.multiSesssion) {
if (this.threads.multiSession) {
return super.getDefaultNodeStyle(node, props);
}
return undefined;
Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/common/debug-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { IJSONSchema, IJSONSchemaSnippet } from '@theia/core/lib/common/json-sch
import { Disposable } from '@theia/core/lib/common/disposable';
import { MaybePromise } from '@theia/core/lib/common/types';

// FXIME: break down this file to debug adapter and debug adapter contribution (see Theia file naming conventions)
// FIXME: break down this file to debug adapter and debug adapter contribution (see Theia file naming conventions)

/**
* DebugAdapterSession symbol for DI.
Expand Down