[file-search] improve results obtained when performing file search

[vince-fugnitto]

What it does

Fixes #5636

Description:

The current logic of the file-search meant that fuzzy results were being returned over exact results due to the limit. This PR quickly addresses that issue by ensuring that exact matches are prioritized, and thus returns better results. The PR has been tested with large workspaces (and even multi-root workspaces) and the performance stayed largely identical. There is likely to be a tradeoff of performance for better results which in the end I believe users would appreciate.

Implementation

The idea is to cancel the search if the exact matches hits the allowed limit.
Only the limit of results is sent over the wire.

How to test

• perform file-search on a large workspace (or multi-root workspace)
• verify the performance and if the results are better than previously (ex: searching for os.ts)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[elaihau]

So the idea is "not stop the search until the number of exact matches exceeds the limit".

The code lowers the "worst-case performance", and should not have major impacts to the "average case performance". I am OK with this change.

[vince-fugnitto]

So the idea is "not stop the search until the number of exact matches exceeds the limit".

The code lowers the "worst-case performance", and should not have major impacts to the "average case performance". I am OK with this change.

Yes, the general idea is to use the limit only for the exact matches (attempt to get the most best possible matches), and some fuzzy results. In the end only the limit is passed over the wire.

It improves the results obtained while also not being too much of a radical change.
I'll get other's opinions on the change before merging :) Thank you for the review!

[vince-fugnitto]

@lmcbout do you mind trying out this pull request for me when you get the chance?

[lmcbout]

I will test it

[lmcbout]

LGTM
Code wise: ok
Testing on Ubuntu and Chrome: works fine, performance is good
Matching result: Great

[vince-fugnitto]

If possible, I'd really like to get more opinions/reviews on this pull request before merging.
I attempted to improve the ordering of search results while keeping the changes/impact to a minimum including performance and complexity.

[akosyakov]

I'm fine to try.

[vince-fugnitto]

I'm fine to try.

Sounds good, we can try to see if the behavior is better, and if anything it is always possible to rollback/revert the changes as they are in history.