Don't throw an error if access to the clipboard is denied. #6516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Nov 8, 2019
| } | ||
| } | ||
| if (permission.state === 'denied') { | ||
| // most likely, the user intentionally denied the access | ||
| this.messageService.error("Access to the clipboard is denied. Check your browser's permission."); | ||
| throw new Error('Access to the clipboard is denied.'); | ||
| this.messageService.warn("Access to the clipboard is denied. Check your browser's permission."); |
There was a problem hiding this comment.
Is not it confusing that we use the same warning message for read and write? Would not it better to have Read access and Write access instead of just Access?
There was a problem hiding this comment.
But there're no separate read/write settings available to the user. It's just general access.
There was a problem hiding this comment.
ok, I was concerned to know from where an error is coming, right now it is not clear whether extension tried to read or write. probably it is not important, let's wait with it.
akosyakov
added
clipboard
|
@akosyakov I've addressed your comments. Thanks for reviewing! |
akosyakov
approved these changes
Nov 8, 2019
Signed-off-by: Artem Zatsarynnyi <[email protected]>
azatsarynnyy
force-pushed
the
az/clipboard
branch
from
b3d3014 to
8d266f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi [email protected]
What it does
When the user has denied access to the clipboard, it should not be treated as an error, by Theia.
The user just needs to be warned about it.
fixes eclipse-che/che#15093
How to test
1/ Run Theia with the test extension https://github.com/azatsarynnyy/test-clipboard-api/blob/master/clipboard-api-test-0.0.1.vsix
2/ Deny the browser accessing the clipboard from Theia page.
3/ Call
Clipboard: read from clipboardcommand from the commands palette.w/o the patch
w/ the patch
Review checklist
Reminder for reviewers