Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] initialize ext storage proxy earlier #6323

Merged
merged 1 commit into from
Oct 4, 2019
Merged

[plugin] initialize ext storage proxy earlier #6323

merged 1 commit into from
Oct 4, 2019

Conversation

akosyakov
Copy link
Member

What it does

  • fix Unknown actor StorageExt error #6305: Initialize ext storage proxy earlier. Otherwise the main side can send events before the plugin manager is initialized leading to exceptions.

How to test

  • install some vs code extension, i.e. go
  • open a project
  • check that console dose not have unknown ext storage service errors

Review checklist

Reminder for reviewers

Otherwise the main side can send events before the plugin manager is initialized leading to exceptions.

Signed-off-by: Anton Kosyakov <[email protected]>
@akosyakov akosyakov requested review from benoitf, evidolob, mmorhun, AlexTugarev, svenefftinge and vince-fugnitto and removed request for benoitf October 3, 2019 15:55
@akosyakov akosyakov added the plug-in system issues related to the plug-in system label Oct 3, 2019
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked successfully for me 👍

I tested using the bracket-pair-colorizer on master and with this change.
On master I could see the error Error: Unknown actor StorageExt, while with this PR, the error was no longer present.

@akosyakov
Copy link
Member Author

Ideally we should not send preferences and storage information twice. Maybe we should just remove it from the plugin manager initialization, and initialize only in corresponding services. @benoitf ?

@akosyakov akosyakov merged commit e3ff100 into master Oct 4, 2019
@akosyakov akosyakov deleted the GH-6305 branch October 4, 2019 06:26
@akosyakov akosyakov restored the GH-6305 branch October 4, 2019 06:26
@akosyakov akosyakov deleted the GH-6305 branch October 4, 2019 06:26
@benoitf
Copy link
Contributor

benoitf commented Oct 4, 2019

AFAIK it was egg and chicken problem (cc @evidolob )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown actor StorageExt error
4 participants