core: fix logic in getToggledHandler
#5906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `isToggled` isn't defined, the command would be considered as not toggled. We want it to be seen as toggled by default instead. Signed-off-by: Paul Maréchal <[email protected]>
|
I think we can update the It should be possible to test the internal state of the methods. |
|
The logic seems incorrect, please see below from testing: 
|
|
Turns out the logic is fine the way it is now :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fix logic issue when looking for a toggled command handler.
Follow up of #5894 (review)
How to test
Register a command handler not defining a
isTogglefunction.Before this patch it would not be shown as toggled.
With this patch it should be shown as toggled.
Review checklist
Reminder for reviewers