Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throttle debug console output #5494

Merged
merged 1 commit into from
Jun 17, 2019
Merged

throttle debug console output #5494

merged 1 commit into from
Jun 17, 2019

Conversation

akosyakov
Copy link
Member

fix #5491 - UI should not freeze with huge amount of output to the debug console

Also found #5493 during testing. It will be addressed with a separate PR.

How to test

svenefftinge
svenefftinge approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can no longer reproduce the freeze situation

@svenefftinge
Copy link
Contributor

I noticed that the console output is not automatically scrolling. At least not reliably but it doesn't seem to be related to this change. Filed: #5495

@akosyakov akosyakov merged commit e6651fb into master Jun 17, 2019
@akosyakov akosyakov deleted the GH-5491 branch June 17, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@tolusha tolusha Awaiting requested review from tolusha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

debug console cannot handle huge amount of output
2 participants
@akosyakov @svenefftinge