[process] Mark as killed when process errors out #4612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some unhandled errors from the tests because we used to not mark processes that errored as `killed`. Also renamed a potential name collision with the global `process` name. Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/process-error
branch
from
1cc548e to
ac8679c
Compare
|
Might merge this with my other PR to change processes, might be easier to fix the build failing now. |
TBF no idea, it should improve things, but the failure in your PR is confusing me, as I can't understand in which case the fields will be undefined, yet it seems to be happening, but not always... Maybe you can just amend your commit without modifications and push back to re-trigger the CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some unhandled errors from the tests because we used to not mark
processes that errored as
killed.Also renamed a potential name collision with the global
processname.Signed-off-by: Paul Maréchal [email protected]
Tried to investigate based on #4556 (comment)
I still think that the code shouldn't fail the way it is written, but maybe I am overlooking something.
Meanwhile, one of the culprits could be the name collision with
process, on whichoutputis indeed undefined...This commit also fix the errors like: https://travis-ci.org/theia-ide/theia/jobs/508469621#L2568