-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mini-browser] Make the mini-browser background white again #4096
[mini-browser] Make the mini-browser background white again #4096
Conversation
@svenefftinge or @akosyakov, I can't reproduce the live-preview flickering issue that you mentioned. I tried running mdBook in Gitpod, but:
|
b597803
to
987f4cf
Compare
I remember that the reasons we limited the features was that is quite limiting what works in an iframe. So we didn't allow to change the URL (it is just a property that can be set). Also the history is using the outer windows history, so going back will eventually leave the IDE all together. The mdbook hot code replacing only works after this change (it exposes the websocket): https://gitpod.io/#https://github.com/svenefftinge/mdBook |
I think it would make sense to limit this PR to only changing the background. And work on the other parts independently. |
Agreed! I'll move the checklist into an issue, and reduce the scope of this PR to the first item.
This doesn't make sense to me. The URL looks editable, but isn't. Also, using But maybe this is linked to another bug, that causes the loading screen to hide the iframe whenever there is an error? (E.g. instead of seeing clear "CSP" or "Content-Encoding" error pages, I still see the "loading" overlay in Gitpod, but deleting that overlay manually using devtools reveals the actual iframe error). I think if we fix the overlay and clearly show the iframe errors, we can make the URLbar editable again (users will probably understand that if you try to open www.google.com there, it won't work, but it's ok because that's not the point of the Preview pane). |
Fixes eclipse-theia#3969 Signed-off-by: Jan Keromnes <[email protected]>
987f4cf
to
301780a
Compare
Thanks for the review! Rebased + signed off. |
Fix #3969 by making the background white again, which is what every web app expects.
(Part of ongoing mini-browser improvements, see #4102.)