Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/ux: styling search options #12697

Merged
merged 2 commits into from
Jul 13, 2023
Merged

ui/ux: styling search options #12697

merged 2 commits into from
Jul 13, 2023

Conversation

vladarama
Copy link
Contributor

What it does

Fixes: #12678

This PR fixes the styling of the search options in the search-in-workspace view to make it more consistent with the rest of Theia.

Before:
Untitled

After:
after

How to test

  1. Open Theia
  2. Go to the search-in-workspace view
  3. Notice the styling of the search options, they should be the same as the ones in the find-widget

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience labels Jul 11, 2023
vince-fugnitto
vince-fugnitto approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look great!

image

@vince-fugnitto vince-fugnitto merged commit e52fc5b into eclipse-theia:master Jul 13, 2023
@vince-fugnitto vince-fugnitto added this to the 1.40.0 milestone Jul 27, 2023
@vladarama vladarama deleted the search-options-styling branch July 31, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience
Projects
PR Backlog
Archived in project
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.

search-in-workspace: improve styling of the search options
2 participants
@vladarama @vince-fugnitto